From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754748AbbCSLUk (ORCPT ); Thu, 19 Mar 2015 07:20:40 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:29859 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbbCSLUh (ORCPT ); Thu, 19 Mar 2015 07:20:37 -0400 X-AuditID: cbfee61b-f79d76d0000024d6-90-550ab1047815 From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <1426611461-690-1-git-send-email-jaegeuk@kernel.org> <1426611461-690-4-git-send-email-jaegeuk@kernel.org> <006d01d06118$a3a23390$eae69ab0$@samsung.com> <20150318175750.GB7461@jaegeuk-mac02> In-reply-to: <20150318175750.GB7461@jaegeuk-mac02> Subject: RE: [f2fs-dev] [PATCH 4/4] f2fs: avoid wrong f2fs_bug_on when truncating inline_data Date: Thu, 19 Mar 2015 19:19:52 +0800 Message-id: <009e01d06236$b9823a60$2c86af20$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQK9rNlQuRPr0w+J/uCqCDMOStWF9wGmgiE4AWHFp18BxI7P+5siqsqw Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOLMWRmVeSWpSXmKPExsVy+t9jQV2WjVyhBh/nSVo8WT+L2eLSIneL PXtPslhc3jWHzYHFY9OqTjaP3Qs+M3l83iQXwBzFZZOSmpNZllqkb5fAlbHxyzOWgsvcFe+3 fmJsYFzO2cXIySEhYCLR9+EGE4QtJnHh3nq2LkYuDiGB6YwSKx/NgXJ+MEr87TsGVsUmoCKx vOM/mC0ioCbRu28KmM0skCkxof8FO0TDeUaJWzefsIEkOAWMJF5f3gxWJCwQL/Hi6VIWEJtF QFVi3ZQtYDavgKXErc5mJghbUOLH5HssEEO1JDZva2KFsOUlNq95ywxxqoLEjrOvGSGOcJPo vzeJHaJGXGLjkVssExiFZiEZNQvJqFlIRs1C0rKAkWUVo2hqQXJBcVJ6rpFecWJucWleul5y fu4mRnDwP5PewbiqweIQowAHoxIPb4Y7V6gQa2JZcWXuIUYJDmYlEd7TZUAh3pTEyqrUovz4 otKc1OJDjNIcLErivEr2bSFCAumJJanZqakFqUUwWSYOTqkGRjuTJfNdz6mazrii+Tlwx6ve HcsCQzdn2+7LPfHKsvz4e1PF2G4GzQNvP2lGa3zvbrvf/TVo1cGFrQJCb13/flSy1IzcrLlv p7+7l8Upb1bx1TO2F+9K9FvfubyM6Ra/wgYG0TA5pijBNxwXnTqTP7fNtVz0Ue7F48+hq7wn 3L4czyhW/7h5jhJLcUaioRZzUXEiAOk8ugN6AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jeageuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Thursday, March 19, 2015 1:58 AM > To: Chao Yu > Cc: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 4/4] f2fs: avoid wrong f2fs_bug_on when truncating inline_data > > Hi, > > On Wed, Mar 18, 2015 at 09:12:00AM +0800, Chao Yu wrote: > > Hi Jaegeuk, > > > > > -----Original Message----- > > > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > > > Sent: Wednesday, March 18, 2015 12:58 AM > > > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > > > linux-f2fs-devel@lists.sourceforge.net > > > Cc: Jaegeuk Kim > > > Subject: [f2fs-dev] [PATCH 4/4] f2fs: avoid wrong f2fs_bug_on when truncating inline_data > > > > > > This patch removes wrong f2fs_bug_on in truncate_inline_inode. > > > > > > When there is no space, it can happen a corner case where i_isze is over > > > MAX_INLINE_SIZE while its inode is still inline_data. > > > > > > The scenario is > > > 1. write small data into file #A. > > > 2. fill the whole partition to 100%. > > > 3. truncate 4096 on file #A. > > > > If we truncate size over MAX_INLINE_DATA, we will convert inline data in > > f2fs_truncate rather than write_begin below. isn't it? > > But, it fails to convert that due to -ENOSPC. :) That makes sense, :) Reviewed-by: Chao Yu Thank,