From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D69C2D0A3 for ; Mon, 9 Nov 2020 16:29:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E058722242 for ; Mon, 9 Nov 2020 16:28:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tessares-net.20150623.gappssmtp.com header.i=@tessares-net.20150623.gappssmtp.com header.b="dQghebCk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729791AbgKIQ26 (ORCPT ); Mon, 9 Nov 2020 11:28:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726796AbgKIQ26 (ORCPT ); Mon, 9 Nov 2020 11:28:58 -0500 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29657C0613CF for ; Mon, 9 Nov 2020 08:28:58 -0800 (PST) Received: by mail-ed1-x544.google.com with SMTP id q3so9406771edr.12 for ; Mon, 09 Nov 2020 08:28:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VcXUbl2f8utqzzFYS4gDk1OqUS8YDWffeiu9Odc0C+A=; b=dQghebCkUm/2O5HtpHQcC3Sq0S1OQ+BRaqC3PuEQsVdOFGAHwD4VkWfptetAQCjl/4 YJETS+0vzIUSWEurflkbpeallB89hLwtr2GzexP1cv0S8YLuJ8jXOUi/AgTWls1unH53 fj8KZS8ozbsQdhEUPV5+9EiWwH+NuAJ7I/TG2tL4x3pil2LOznG2xYbvKh5E3GJq+QtI OEyHOp08I9/1XkNnW3UM2vUoWkYpMMgQXSPpYFwlJ4p0fUY9PDSaIVN2WbaKZ5DR5Dqy sLyuAiQtU92/SH4a/d0t8IxYLIX5nIgpNlASaAgXLRI7+9HgTQTL1eFtMtOAPpUmXV/e M7NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VcXUbl2f8utqzzFYS4gDk1OqUS8YDWffeiu9Odc0C+A=; b=UJuxcovSbwP9SL+pnlYIiLuSm70hHV2FrHXp4W/FfYixtflaz7xN5Iq9SN9pe7xSBu w8Pr1Ygw9zeF0pkArBFEYkyNoPVKc4PDJF6KVxYI6C/QRrAHe8LuHbUvVHG32gMqMoQ8 DmCfVyHPoP5nuo573PHDwfBy323UFqAO8ZSzrfdHj25/xVmx5X5i4kfgWrxwI997KW1t +ZGBMf34sXt8Pl4heX0b4lMwHjS7ZnPtX8XYLx+7u354mEE6gYIgfcQuw7yAsmPCLDuK b9ncI4etmgUqHsWmwwqsh9RjpMyJLzVK94B+Az2uq7g13cGQXJN/B2Q8zLr0t/zp0WQ2 Ig7A== X-Gm-Message-State: AOAM531IYamwi814ud8pSKEUBMSYXQUDPZucyQn6x7Sg5e6aib84jFtQ uslbxH5weDTueZtYPCbWZzZcPw== X-Google-Smtp-Source: ABdhPJw9Ev8Usg+y6pJcQxDa4Fc6Eq+iqNDrk/4dsYlJhXWuzODI/Q5M+uLoEgvINzWOVj9kdpa0bQ== X-Received: by 2002:a50:a689:: with SMTP id e9mr6198994edc.233.1604939336772; Mon, 09 Nov 2020 08:28:56 -0800 (PST) Received: from tsr-lap-08.nix.tessares.net ([2a02:578:85b0:e00:42d:4528:36bd:c4ae]) by smtp.gmail.com with ESMTPSA id b12sm9204372edn.86.2020.11.09.08.28.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2020 08:28:56 -0800 (PST) To: Geliang Tang , Mat Martineau , "David S. Miller" , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org, Dan Carpenter References: From: Matthieu Baerts Subject: Re: [MPTCP][PATCH net 1/2] mptcp: fix static checker warnings in mptcp_pm_add_timer Message-ID: <009ea5da-8a44-3ea2-1b9f-a658a09f3396@tessares.net> Date: Mon, 9 Nov 2020 17:28:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geliang, Dan, On 09/11/2020 14:59, Geliang Tang wrote: > Fix the following Smatch complaint: Thanks for the report and the patch! > net/mptcp/pm_netlink.c:213 mptcp_pm_add_timer() > warn: variable dereferenced before check 'msk' (see line 208) > > net/mptcp/pm_netlink.c > 207 struct mptcp_sock *msk = entry->sock; > 208 struct sock *sk = (struct sock *)msk; > 209 struct net *net = sock_net(sk); > ^^ > "msk" dereferenced here. > > 210 > 211 pr_debug("msk=%p", msk); > 212 > 213 if (!msk) > ^^^^ > Too late. > > 214 return; > 215 > > Fixes: 93f323b9cccc ("mptcp: add a new sysctl add_addr_timeout") > Reported-by: Dan Carpenter > Signed-off-by: Geliang Tang > Reviewed-by: Dan Carpenter A small detail (I think): the Signed-off-by of the sender (Geliang) should be the last one in the list if I am not mistaken. But I guess this is not blocking. Reviewed-by: Matthieu Baerts Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net