From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758530AbbJ3GlW (ORCPT ); Fri, 30 Oct 2015 02:41:22 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:49669 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbbJ3GlU convert rfc822-to-8bit (ORCPT ); Fri, 30 Oct 2015 02:41:20 -0400 X-AuditID: cbfec7f5-f794b6d000001495-b5-5633110d9944 From: Pavel Fedin To: "'Pankaj Dubey'" Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "'linux-samsung-soc'" , linux-kernel@vger.kernel.org, "'Rob Herring'" , "'Pawel Moll'" , "'Mark Rutland'" , "'Ian Campbell'" , "'Kumar Gala'" , "'Kukjin Kim'" , "'Krzysztof Kozlowski'" References: In-reply-to: Subject: RE: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410 Date: Fri, 30 Oct 2015 09:41:15 +0300 Message-id: <009f01d112dd$fab40830$f01c1890$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Thread-index: AQG1Qj+spkOVIgDiU4jMHmu53IoLAgIbXF5mAeYez/yemyrKEA== Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t/xq7q8gsZhBnPPKVrMP3KO1aL/zUJW i3OvVjJavH5haNH/+DWzxabH11gtLu+aw2Yx4/w+Joul1y8yWSza+oXdYsL0tSwWrXuPsDvw eKyZt4bR43JfL5PHyuVf2Dw2repk89i8pN6jb8sqRo/Pm+QC2KO4bFJSczLLUov07RK4Mvav e89c8EKsYuW6dywNjJv5uxg5OSQETCRenvjKCmGLSVy4t54NxBYSWMoo8bezuouRC8j+zihx YNc/dpAEm4C6xOmvH1hAbBEBXYlZj94wgxQxC+xhluhecYoNouMso8T/xW+Zuhg5ODgFgiWm zBQHaRAWsJNY0b4YrJlFQFWi7VwjmM0rYCnRdnsvlC0o8WPyPRaQVmagZVOm5IKEmQW0JZ68 uwB1qILEjrOvGSFucJLY2n+HBaJGRGLav3vMExiFZiGZNAth0iwkk2Yh6VjAyLKKUTS1NLmg OCk910ivODG3uDQvXS85P3cTIyTavu5gXHrM6hCjAAejEg/vjwSjMCHWxLLiytxDjBIczEoi vL8vAYV4UxIrq1KL8uOLSnNSiw8xSnOwKInzztz1PkRIID2xJDU7NbUgtQgmy8TBKdXAeLBM 7mhEOH/fDs9eLf1XHj0W1R1dgqmVd6bfMtl5h+XrM01Bdf0vXZduTrzaLjU5p1/fc8HJxf6d m9wVNqseFNZY353x5eOP5PuJW0ocNkY/k+H7nDj1tta3e8VXeS92bgm01WpSvhb02aRqmcaF q5InKlP7n/1yWh/W6uxXmHTg5Ku+E0bcSizFGYmGWsxFxYkAQcQ8urICAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! > -----Original Message----- > From: linux-samsung-soc-owner@vger.kernel.org [mailto:linux-samsung-soc-owner@vger.kernel.org] > On Behalf Of Pankaj Dubey > Sent: Thursday, October 29, 2015 8:28 PM > To: Pavel Fedin > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc; > linux-kernel@vger.kernel.org; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; > Kukjin Kim; Krzysztof Kozlowski > Subject: Re: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410 > > Hi Pavel, > > On 29 October 2015 at 18:12, Pavel Fedin wrote: > > This machine uses own SoC device tree file, add missing part. > > > > Signed-off-by: Pavel Fedin > > --- > > arch/arm/boot/dts/exynos5410.dtsi | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi > > index 4603356..da6a8fa0e 100644 > > --- a/arch/arm/boot/dts/exynos5410.dtsi > > +++ b/arch/arm/boot/dts/exynos5410.dtsi > > @@ -101,6 +101,15 @@ > > reg = <0x10000000 0x100>; > > }; > > > > + sromc: sromc@12250000 { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > We do not need to specify these three properties as they are already > present in parent node "soc". We do, otherwise dtc complains about defaults of #address-cells = 2 and #size-cells=1, and without empty "ranges" subnode's resources are not correctly translated. > > > + compatible = "samsung,exynos-srom"; > > + reg = <0x12250000 0x14>; > > + }; > > + > > pmu_system_controller: system-controller@10040000 { > > compatible = "samsung,exynos5410-pmu", "syscon"; > > reg = <0x10040000 0x5000>; > > @@ -133,6 +142,12 @@ > > <10 &gic 0 130 0>, > > <11 &gic 0 131 0>; > > }; > > + > > + arch_timer { > > + compatible = "arm,armv7-timer"; > > + clock-frequency = <24000000>; > > + }; > > + > > This change should not be part of this patch. Ooops, thank you very much, this should not have been here at all. This is a leftover from my experiments, i was tracing DT parsing code and added it just for test, to see why timer gets probed as a subnode. Just forgot to remove it afterwards and it slipped into the patch. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia