From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753528AbaHSTfO (ORCPT ); Tue, 19 Aug 2014 15:35:14 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37059 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbaHSTfM convert rfc822-to-8bit (ORCPT ); Tue, 19 Aug 2014 15:35:12 -0400 From: "Murphy, Dan" To: Dmitry Torokhov CC: "mark.rutland@arm.com" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v6] input: drv260x: Add TI drv260x haptics driver Thread-Topic: [PATCH v6] input: drv260x: Add TI drv260x haptics driver Thread-Index: AQHPuKBG/Qme4vynlkWiIpuXx8CBGw== Date: Tue, 19 Aug 2014 19:35:06 +0000 Message-ID: <00FC9A978A94B7418C33AFAE8A35ED49DEC1EF@DFLE09.ent.ti.com> References: <1408117670-19750-1-git-send-email-dmurphy@ti.com> <20140819192401.GA32080@core.coreip.homeip.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.170.170.90] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dmitry On 08/19/2014 02:24 PM, Dmitry Torokhov wrote: > Hi Dan, > > On Fri, Aug 15, 2014 at 10:47:50AM -0500, Dan Murphy wrote: >> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig >> index 2ff4425..99f6762 100644 >> --- a/drivers/input/misc/Kconfig >> +++ b/drivers/input/misc/Kconfig >> @@ -676,4 +676,13 @@ config INPUT_SOC_BUTTON_ARRAY >> To compile this driver as a module, choose M here: the >> module will be called soc_button_array. >> >> +config INPUT_DRV260X_HAPTICS >> + tristate "TI DRV260X haptics support" >> + depends on INPUT && I2C > > This also needs "select REGMAP_I2C" > This one is OK >> + help >> + Say Y to enable support for the TI DRV260X haptics driver. >> + >> + To compile this driver as a module, choose M here: the >> + module will be called drv260x-haptics. >> + > > [...] > >> +#ifndef _LINUX_DRV260X_PDATA_H >> +#define _LINUX_DRV260X_PDATA_H >> + >> +struct drv260x_platform_data { >> + int enable_gpio; > > I do not see this used anywhere. But this is actually used here haptics->enable_gpio = devm_gpiod_get(&client->dev, "enable"); for the non-dt case > >> + u32 library_selection; >> + u32 mode; >> + u32 vib_rated_voltage; >> + u32 vib_overdrive_voltage; >> +}; >> + >> +#endif > > I fixed up the above issues and did a few more formatting changes and applied > to my 'next' branch. Please take a peek and holler if you see something wrong. > > Thanks. > -- ------------------ Dan Murphy