From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753875AbaHUTPJ (ORCPT ); Thu, 21 Aug 2014 15:15:09 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:45152 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753652AbaHUTPH convert rfc822-to-8bit (ORCPT ); Thu, 21 Aug 2014 15:15:07 -0400 From: "Murphy, Dan" To: Sergei Shtylyov , "linux-input@vger.kernel.org" , "dmitry.torokhov@gmail.com" CC: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/2] doc: dt/bindings: input: introduce TI DRV2667 haptic driver description Thread-Topic: [PATCH 1/2] doc: dt/bindings: input: introduce TI DRV2667 haptic driver description Thread-Index: AQHPvWxlh8T1IOIo2Uaji+p6cWyocw== Date: Thu, 21 Aug 2014 19:14:40 +0000 Message-ID: <00FC9A978A94B7418C33AFAE8A35ED49DF0ABE@DFLE09.ent.ti.com> References: <1408645143-25690-1-git-send-email-dmurphy@ti.com> <1408645143-25690-2-git-send-email-dmurphy@ti.com> <53F642AF.3070200@cogentembedded.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.170.170.90] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sergei Thanks for the additional comments On 08/21/2014 02:04 PM, Sergei Shtylyov wrote: > Hello. > > On 08/21/2014 10:19 PM, Dan Murphy wrote: > >> DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators. >> Adding dt binding for this part > >> Signed-off-by: Dan Murphy >> --- >> .../devicetree/bindings/input/ti,drv2667.txt | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt > >> diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt >> new file mode 100644 >> index 0000000..525216d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt >> @@ -0,0 +1,18 @@ >> +Texas Instruments - drv2667 Haptics driver >> + >> +The drv2667 uses serial control bus communicates through I2C protocols >> + >> +Required properties: >> + - compatible - "ti,drv2667" - DRV2667 >> + - reg - I2C slave address >> + - vbat-supply - Required supply regulator >> + >> +Example: >> + >> +drv2667: drv2667@59 { > > The ePAPR standard [1] has something to say on this matter: What is this reference? Did not know this existed so wanted to read up on it. I can change it to haptics or vibrator > > "The name of a node should be somewhat generic, reflecting the function of the > device and not its precise programming model." > >> + compatible = "ti,drv2667"; > > Indented too much to the right. One tab to many. Got it > >> + reg = <0x59>; > > Still no "vbat-supply"... :-/ > Still have not sent in v2 of the patch yet. Waiting on other comments. >> +}; > [...] > > WBR, Sergei > > -- ------------------ Dan Murphy