mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Murphy, Dan" <dmurphy@ti.com>
To: "Balbi, Felipe" <balbi@ti.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] doc: dt/bindings: input: Fix drv260x binding document
Date: Fri, 22 Aug 2014 14:49:52 +0000	[thread overview]
Message-ID: <00FC9A978A94B7418C33AFAE8A35ED49DF2059@DFLE09.ent.ti.com> (raw)
In-Reply-To: <20140822144524.GE22707@saruman.home>

Felipe

On 08/22/2014 09:45 AM, Balbi, Felipe wrote:
> Hi,
> 
> On Fri, Aug 22, 2014 at 09:25:13AM -0500, Murphy, Dan wrote:
>> Felipe
>>
>> On 08/22/2014 09:15 AM, Balbi, Felipe wrote:
>>> On Fri, Aug 22, 2014 at 09:12:21AM -0500, Dan Murphy wrote:
>>>> Update the drv260x dt binding document:
>>>> - Change the node name to the devices function not the
>>>> device name.
>>>> - Add vbat-supply to the example.
>>>> - Fix indentation of the example.
>>>>
>>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>>> ---
>>>>  .../devicetree/bindings/input/ti,drv260x.txt       |   19 ++++++++++---------
>>>>  1 file changed, 10 insertions(+), 9 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/input/ti,drv260x.txt b/Documentation/devicetree/bindings/input/ti,drv260x.txt
>>>> index a9c8519..214e25d 100644
>>>> --- a/Documentation/devicetree/bindings/input/ti,drv260x.txt
>>>> +++ b/Documentation/devicetree/bindings/input/ti,drv260x.txt
>>>> @@ -37,15 +37,16 @@ Optional properties:
>>>>  			  3.2 v.
>>>>  Example:
>>>>  
>>>> -drv2605l: drv2605l@5a {
>>>> -		compatible = "ti,drv2605l";
>>>> -		reg = <0x5a>;
>>>> -		enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>>>> -		mode = <DRV260X_LRA_MODE>;
>>>> -		library-sel = <DRV260X_LIB_LRA>;
>>>> -		vib-rated-mv = <3200>;
>>>> -		vib-overdriver-mv = <3200>;
>>>> -};
>>>> +haptics:@5a {
>>>
>>> haptics: haptics@5a ??
>>>
>>
>> I found both types of entries in the bindings docs.
>> There is no consistency within the input bindings documentation.
> 
> I could swear neither two types have a colon character between node name
> and its base address.
> 

I will add it to the fixes.

Dan

-- 
------------------
Dan Murphy

      reply	other threads:[~2014-08-22 14:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22 14:12 Dan Murphy
2014-08-22 14:15 ` Felipe Balbi
2014-08-22 14:25   ` Murphy, Dan
2014-08-22 14:45     ` Felipe Balbi
2014-08-22 14:49       ` Murphy, Dan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00FC9A978A94B7418C33AFAE8A35ED49DF2059@DFLE09.ent.ti.com \
    --to=dmurphy@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®