From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758647AbbJ3G6L (ORCPT ); Fri, 30 Oct 2015 02:58:11 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:42178 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757901AbbJ3G6I (ORCPT ); Fri, 30 Oct 2015 02:58:08 -0400 X-AuditID: cbfec7f5-f794b6d000001495-89-563314fd0852 From: Pavel Fedin To: "'Krzysztof Kozlowski'" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "'Rob Herring'" , "'Pawel Moll'" , "'Mark Rutland'" , "'Ian Campbell'" , "'Kumar Gala'" , "'Kukjin Kim'" References: <56330E6E.50003@samsung.com> In-reply-to: <56330E6E.50003@samsung.com> Subject: RE: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration Date: Fri, 30 Oct 2015 09:58:03 +0300 Message-id: <00a101d112e0$537a18e0$fa6e4aa0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQG1Qj+spkOVIgDiU4jMHmu53IoLAgIrGUotAS0y68OeoHfXsA== Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsVy+t/xK7p/RYzDDJ7skLWYf+Qcq0X/m4Ws FuderWS0eP3C0KL/8Wtmi02Pr7FaXN41h81ixvl9TBZLr19kspgwfS2LReveI+wO3B5r5q1h 9Ljc18vksXL5FzaPTas62Tw2L6n36NuyitHj8ya5APYoLpuU1JzMstQifbsErowTK24xFXzm rejZcpW1gbGZq4uRk0NCwETi1apmFghbTOLCvfVsXYxcHEICSxklvr28yQzhfGeUeHp5ElgV m4C6xOmvH1hAEiICuxglfm3pBnOYBd4wSpxa9pgZrv/iqoNMIC2cApoS5+YtYgexhQXCJE73 fGcFsVkEVCXeTdwJ1MDBwStgKfHwjDhImFdAUOLH5Htg25gFtCTW7zzOBGHLS2xe85YZ4lYF iR1nXzOC2CICThLP/72GqheRmPbvHvMERqFZSEbNQjJqFpJRs5C0LGBkWcUomlqaXFCclJ5r pFecmFtcmpeul5yfu4kREmtfdzAuPWZ1iFGAg1GJh/dHglGYEGtiWXFl7iFGCQ5mJRHe35eA QrwpiZVVqUX58UWlOanFhxilOViUxHln7nofIiSQnliSmp2aWpBaBJNl4uCUamBsbeOb4rLg iqvIl23n5EPn/vSo93NXe1+9w/Q8n2HE+507Xu9pnNJ9YfPrlQ3/ey4KcLdwVq1/cvFryF/O tZsyj3oum1KwoFRY/JjRVuFTgec3uvX+u7rR51Du5GV2Ak8PnOq7sYvxV370cYtQk7cvtM+V nAhW4J5XybD0oEp8695pYpXT96xIUWIpzkg01GIuKk4EACqDJb2xAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! > > Add documentation for new subnode properties, allowing bank configuration. > > Based on u-boot implementation, but heavily reworked. > > Please, carefully look at: > Documentation/devicetree/bindings/net/gpmc-eth.txt > Documentation/devicetree/bindings/bus/ti-gpmc.txt Thank you very much. Indeed, this looks very similar. By the way, should i document smsc over sromc in the same manner, writing devicetree/bindings/net/sromc-eth.txt? This is a short reply for now, i'll make longer one (or just a new version) after studying these existing bindings and trying to apply them. Pankaj: > > +&sromc { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&srom_ctl>, <&srom_ebi>; > > + > > + ethernet@07000000 { > > + compatible = "smsc,lan9115"; > > + reg = <0x07000000 0x10000>; > > + phy-mode = "mii"; > > + interrupt-parent = <&gpx0>; > > + interrupts = <5 8>; > > + reg-io-width = <2>; > > + smsc,irq-push-pull; > > + smsc,force-internal-phy; > > + > > + samsung,srom-bank = <3>; > > + samsung,srom-data-width = <2>; > > + samsung,srom-timing = <1 9 12 1 9 1 1>; > > I think this is not correct. We can't change binding of "smsc,lan9115" > which is already documented here [1]. These samsung specific srom > properties should be in srom node or its subnode, but not in this way. So, if you look at gpmc-eth.txt, you'll see that this approach is perfectly valid (this is a reply to another msg, just don't want to post one more single-line reply). Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia