From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754380AbbKYOBW (ORCPT ); Wed, 25 Nov 2015 09:01:22 -0500 Received: from m50-132.163.com ([123.125.50.132]:33923 "EHLO m50-132.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753484AbbKYOBU (ORCPT ); Wed, 25 Nov 2015 09:01:20 -0500 From: Geliang Tang To: "Theodore Ts'o" , Andreas Dilger Cc: Geliang Tang , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] fs/ext4: use list_last_entry instead of list_entry Date: Wed, 25 Nov 2015 21:59:47 +0800 Message-Id: <00a35da75dd347ea574b4d0e6c30da6f0eae0c30.1448459920.git.geliangtang@163.com> X-Mailer: git-send-email 2.5.0 X-CM-TRANSID: DNGowEBJWULWvlVWblK8AQ--.4203S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Gw4fGr1kKFykGw1kKw1xXwb_yoW3Grc_ua y2yr409w43GFWIka1Fq3WSqr9IvF1S9r4kZFWxtry3ZFn8AFWDWa4kZw4xWFyDGr4a9rZI kF1kXFyxGr18XjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUbKiiPUUUUU== X-Originating-IP: [116.77.146.156] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiMBi9mVWBSreQPgAAsL Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To make the intention clearer, use list_last_entry instead of list_entry. Signed-off-by: Geliang Tang --- fs/ext4/readpage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c index 5dc5e95..ea97d5979 100644 --- a/fs/ext4/readpage.c +++ b/fs/ext4/readpage.c @@ -163,7 +163,7 @@ int ext4_mpage_readpages(struct address_space *mapping, prefetchw(&page->flags); if (pages) { - page = list_entry(pages->prev, struct page, lru); + page = list_last_entry(pages, struct page, lru); list_del(&page->lru); if (add_to_page_cache_lru(page, mapping, page->index, mapping_gfp_constraint(mapping, GFP_KERNEL))) -- 2.5.0