From: Johannes Berg <johannes@sipsolutions.net>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>, Stanislaw Gruszka <stf_xl@wp.pl>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Jianhao Xu <jianhao.xu@seu.edu.cn>
Subject: Re: [PATCH] wifi: iwlegacy: serialize watchdog updates with device teardown
Date: Mon, 05 Oct 2026 15:23:21 +0200 [thread overview]
Message-ID: <00a4a6b9aec9329b5d5901c5ce72e2cd3203f2d4.camel@sipsolutions.net> (raw)
In-Reply-To: <20261004114519.1233305-1-runyu.xiao@seu.edu.cn>
On Sun, 2026-10-04 at 19:45 +0800, Runyu Xiao wrote:
> The writable wd_timeout debugfs file changes il->cfg->wd_timeout, but the
> iwl3945 configuration is shared and const. The handler also rearms the
> watchdog without taking il->mutex. The down paths hold this mutex, delete
> the timer, and then free the TX queues, so an unlocked debugfs write can
> rearm the timer after deletion. The callback can then access the queues
> after they have been freed.
>
> Store wd_timeout in per-device state. Serialize the debugfs update with
> the down paths and only arm the watchdog while TX queues exist. Use
> READ_ONCE() and WRITE_ONCE() for accesses that do not hold il->mutex.
>
That's a stupid commit log, I can see what you changed.
johannes
prev parent reply other threads:[~2026-10-05 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 11:45 Runyu Xiao
2026-10-05 13:23 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00a4a6b9aec9329b5d5901c5ce72e2cd3203f2d4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Julia.Lawall@lip6.fr \
--cc=jianhao.xu@seu.edu.cn \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=runyu.xiao@seu.edu.cn \
--cc=stable@vger.kernel.org \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®