From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751312AbcBLTc4 (ORCPT ); Fri, 12 Feb 2016 14:32:56 -0500 Received: from 5520-maca-inet1-outside.broadcom.com ([216.31.211.11]:49031 "EHLO mail-irv-18.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbcBLTcz (ORCPT ); Fri, 12 Feb 2016 14:32:55 -0500 Subject: Re: [PATCH 1/3] i2c: iproc: Add recovery mechanism in error case To: Wolfram Sang , Ray Jui References: <1453940842-9658-1-git-send-email-rjui@broadcom.com> <1453940842-9658-2-git-send-email-rjui@broadcom.com> <20160212193119.GR1520@katana> Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Icarus Chau From: Ray Jui Message-ID: <00a4c0fe-962c-3e76-fb53-1c5eadb95af9@broadcom.com> Date: Fri, 12 Feb 2016 11:32:53 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160212193119.GR1520@katana> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/12/2016 11:31 AM, Wolfram Sang wrote: >> +static int bcm_iproc_i2c_init(struct bcm_iproc_i2c_dev *iproc_i2c); >> +static void bcm_iproc_i2c_enable_disable(struct bcm_iproc_i2c_dev *iproc_i2c, >> + bool enable); > > Can't we move these functions instead of having the extra declarations? > I had the same opinion during our internal review, :) I'll do that in the next revision of this patch set. Thanks, Ray