From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD4E3E3DBB for ; Tue, 24 Mar 2026 10:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774348762; cv=none; b=VAd+B/a24ExttXGETOu92WI8QNRzqhyfi7TkRHooUXm5A7xEH/4S9SHWQmPI9Uly1+z3Gx2LuDLoZTFDEMiI5xGfTD4ciajoi8TwAQAtlKxcgrZV67kGdEzXHKGQVJY/fpzu4z/Ujlg7Bet6WJUZUwUqON5KnhtEUe/xjGia+X4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774348762; c=relaxed/simple; bh=aixy/4nOGtVTADyTkPYzo4GgfdqV1G72q2wVa/sm6ZQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oyU8pcCzCHtGrnZXbEgdKloFFRMCeMtiFxxXxnOc3FX+XJndYoPdVM5ZI148cP5XbpIlTO804XF0wkTUmrdOrd+ulh6+wSj7xAYv3KoY1OOpWYlFOSMjKswwo8HJtPQ+coYkmWdcp8U/FXtnWKs+5OygA62e7T+K0+E5HNwY3EY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ncx6ADOr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XLpkGrBL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ncx6ADOr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XLpkGrBL" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O9V67T891021 for ; Tue, 24 Mar 2026 10:39:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Uj5qYX8FhfQc2+1CHGK1yl39nh7ddqgU8t5AUa3/6Rc=; b=ncx6ADOr+KwUM7yI 769Cw/e6gqp0AtD4FjBfrfcy+ogQg3dmuA+2FfDTeL2P1L5F5W5jzU2WP+nxHeTS GxzENAL/7mtjsP7lUfry9BGJ7qERXd9o2+1EsB4yPDTwoMjwE+CxHMcHbdbwv09S 2LpHS91tNZiXYVY/ZtG3vipFit7aH+aOXb4eAUxeRPlORcoHS5nhTsKCtY2nTnae Ask54iUCBYGs3Z5Mkcnrj8j7oNlcrWmtqb5iwjDFy2AQlHgcoCYcdPiGlcYwcW/+ 4s3R+Wf9jQFeIWOP0PlijQtSz/MZUdUokCIsE0W2EptAZIzcjkuIUdZFY53e3uUf njloWA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d3k1x9dmk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 10:39:17 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b060c14ccbso132701025ad.0 for ; Tue, 24 Mar 2026 03:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774348757; x=1774953557; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Uj5qYX8FhfQc2+1CHGK1yl39nh7ddqgU8t5AUa3/6Rc=; b=XLpkGrBLfN52GP0hjTk/mMOAZEF+996DGKKu9ormubxK/fClLPoRvhguymZVvJfItc zFmSwRQyoAioglPjvImS69ERvwx7ei/4VeP7hcgxoxv6U5IaDDKSm48/8CphrsrPjSdP UUKwIDRmfEOrbE9ijfEv7mMAdogWw7lpu6cuMZ8zs+d2pLWi9yYLHohu6I1PvlEDJr9/ 1MSR0R5WXRO3YtKkcwwTrdFGES+sdgjG7IwG8SXaUXBetKbW6Czoqr5hkpJEL1lvYekb oOypvYwqQmAf5BnUZEUS0OBEJanrvhOfGMCiPTaRG6WPi2cPRH1GBwZBRs2+EJlHvKJz jNCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774348757; x=1774953557; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Uj5qYX8FhfQc2+1CHGK1yl39nh7ddqgU8t5AUa3/6Rc=; b=GrgLV3ig2/kJeRuQZ6aWeUu3fgYGQzTSyk7PrIB5/b1ybNtmI13Uw/DIioYri+kbmT FZXi3/1Reutbg5/KFqiN+dWopMQMkH5tL+mATG9xPesm0G40Jbyjs0F0vSk8QjkqtR3t nQomjfO3rd4BqrN1hZp/V6h9fdSr89fvdg5CMd5Y5FyKTdkUrB9rPr2Kzqb9vLP/sQNb uCZj8mah0kt8s2oG7WQHutQwa9ho5DCaae3fiPjUCAgQxjuQ6ROaEOBGFTH9vMYawaUc tiLvGlxS4y4SeqbuSPDEVpMEyBoG4D22B6cMX6IbG1Vl+YL/WF5NzXBAfWhQw2yiPcYs iGiA== X-Forwarded-Encrypted: i=1; AJvYcCW6fLJfse3CMQpQ/cEGKZdraTYJ3fpC1Ra5EK8EQ5AIlxFtKnY09wfIp14tIMmnDwgSyXQvuafgMo2UWpU=@vger.kernel.org X-Gm-Message-State: AOJu0YwZBNdfwqUYWyS8G3zJb2XXpl+EU8dzDU+ewjpQpcLNbWyRQx9g 1dE1Hmd6cSsxrvVvZ0kj2yjL0409Fl6Uda3zXZSpVhY3p2CPmc9wZunIAPtCQd+hh+XzGG69gxE KvmSitWMu8DXE/ZAJwAfkIHoY2iip1xuVAAu1Jnbd9xDi+4URPiMKTQC/QltMEYj+RXE= X-Gm-Gg: ATEYQzwfc5zquxYv63NVaZUoYwvD5rtY9G1q4XoWbe94dz3u27Mg+7aoSHtsNgzizR6 OoI3d6bq2vmWiJujKHBMA6g0b6V5TH620LqStzeAS0n6SctCM+HH1Xn3YwXk/3kaUUNPN9v2aTy wtEnUzZwk2Dmzmj1DsHG+C3tZN/U2OoLqHh8qzgobmSbQFkjt2eIGm4GhyRRi+hT201mfUbi5mG r+T45IhUITJwVTKvOo0xQhwWmhFsdPtpSmAi58SXPyt73JhR8NWoA8D2PMlenJwZo+M9vC3+KhO bDyY3ZgAqpmglXCgscWOEkyG33iieUj+otqDfKhrOqQcE6v8JKO7n94+wjBy7VLHLqKSTjT2gNg QGCGpjo9HAvPzO5RyGRAEKdSmqaXkpWvn6THXLc3tOSwRiGOMLiyV X-Received: by 2002:a17:903:41ce:b0:2ae:508e:5019 with SMTP id d9443c01a7336-2b08271fb32mr146163385ad.20.1774348756685; Tue, 24 Mar 2026 03:39:16 -0700 (PDT) X-Received: by 2002:a17:903:41ce:b0:2ae:508e:5019 with SMTP id d9443c01a7336-2b08271fb32mr146163185ad.20.1774348756210; Tue, 24 Mar 2026 03:39:16 -0700 (PDT) Received: from [10.218.44.178] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083527f90sm137972405ad.19.2026.03.24.03.39.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 03:39:15 -0700 (PDT) Message-ID: <00a59d9b-cda7-406d-a53f-33ccf1ee4817@oss.qualcomm.com> Date: Tue, 24 Mar 2026 16:09:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/11] arm64: dts: qcom: sm8550: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-9-e36044bbdfe9@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-9-e36044bbdfe9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA4NCBTYWx0ZWRfX/uo0lg+5GPl8 3VKmdnpUyakfjK2hE+tAlNbiI/tivNpZ2igRqjuN+pJNZCE1C130lr9ytJ3LvX2Q6Is1eDMEVby rs8doxOLJ+ZR1oA1/WcDLm3i5Bxhlxu6L4kaVjURpnMxWzM9CzTWQTvTFYKe425hlff40ejTYam 9dDU6dQdNCVa3w2XLl7EW8R2uVBXZz0/ZR4GrbOdVz7SqreqoYSNb9pEEMvB6ZjDBUyLEGewWe8 xmEtwBImZlGg4l2eM4vITM6yDqVC4Sf1FfUY/IL/i7cQBJAQhOmnkl90mdAm5UiY8XaKHBSDly0 ehyaqgcKsOcAlVut8Q6isL1QlS1jvA/+lwBvuRm9CN+ZHFJfceWt9NmOzSVMNQn2B3DPlvYxq7L mdCoFdiCjBmAlSIJPrfWILTWKDTrlv+G+nYObO9sQFGpIwQK5pb6UB2/vFEIQr/pUq6h7jEttDI PpkpH94ZLbnXyd7CyRA== X-Proofpoint-ORIG-GUID: 51LT5bvnmOniF2CvmeBFCK3s6qrLqs22 X-Authority-Analysis: v=2.4 cv=O880fR9W c=1 sm=1 tr=0 ts=69c269d5 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=RcdfdvLsBkETvr5PKcUA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: 51LT5bvnmOniF2CvmeBFCK3s6qrLqs22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 malwarescore=0 clxscore=1015 phishscore=0 adultscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240084 On 3/23/2026 2:48 PM, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the UFS_PHY_GDSC power domain is enabled. Specify both the > UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8550. > > Fixes: b8630c48b43fc ("arm64: dts: qcom: sm8550: Add the Inline Crypto Engine node") > Reviewed-by: Konrad Dybcio > Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh -- Regards Kuldeep