From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbcFUL3Q (ORCPT ); Tue, 21 Jun 2016 07:29:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47617 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751189AbcFUL3O (ORCPT ); Tue, 21 Jun 2016 07:29:14 -0400 Subject: Re: [PATCH] ipmi: set si_trydefaults=0 for ARM64 To: minyard@acm.org, openipmi-developer@lists.sourceforge.net References: <1466447175-14263-1-git-send-email-tcamuso@redhat.com> <576858C5.2080000@acm.org> Cc: linux-kernel@vger.kernel.org From: Tony Camuso Message-ID: <00ac61b8-3bf0-8e65-2307-ac7e4e60c294@redhat.com> Date: Tue, 21 Jun 2016 07:20:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <576858C5.2080000@acm.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 21 Jun 2016 11:20:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2016 04:57 PM, Corey Minyard wrote: > On 06/20/2016 01:26 PM, Tony Camuso wrote: >> Port I/O space does not exist in ARM64 and is not mapped. Attempts to >> access it on ARM systems cause stack traces and worse. > > At this point, I think it is best to just completely pull out all concept > of "default addresses" in the IPMI driver. The defaults were disabled > by default in 3.16, this is as good an impetus as any to just get rid > of them. > > If you want, you can do a patch, or I can pull them out if you would > prefer that. I'll give it a go. Should have something later today. Regards, Tony > > Thanks, > > -corey > >> Signed-off-by: Tony Camuso >> --- >> drivers/char/ipmi/ipmi_si_intf.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c >> index 615abbf..85dcc86 100644 >> --- a/drivers/char/ipmi/ipmi_si_intf.c >> +++ b/drivers/char/ipmi/ipmi_si_intf.c >> @@ -3841,6 +3841,11 @@ static int init_ipmi_si(void) >> spmi_find_bmc(); >> #endif >> +#ifdef CONFIG_ARM64 >> + /* Don't touch port io space */ >> + si_trydefaults = 0; >> +#endif >> + >> #ifdef CONFIG_PARISC >> register_parisc_driver(&ipmi_parisc_driver); >> parisc_registered = true; >