From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <cang@codeaurora.org>
Cc: jaegeuk@kernel.org, asutoshd@codeaurora.org,
nguyenb@codeaurora.org, hongwus@codeaurora.org,
linux-scsi@vger.kernel.org, kernel-team@android.com,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Sujit Reddy Thumma <sthumma@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
Yaniv Gardi <ygardi@codeaurora.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs
Date: Sat, 6 Feb 2021 18:50:37 -0800 [thread overview]
Message-ID: <00ae0fb0-4c35-686b-857c-b6cba40be83a@acm.org> (raw)
In-Reply-To: <cf50ecf7a245674f8aee917455a7ccfa@codeaurora.org>
On 2/4/21 10:09 PM, Can Guo wrote:
> That code is wrong. The Task Tag in Dword_0 should be the real tag we
> allocated for TMR. The transfer request Task Tag which we are trying to
> abort is given in Dword_5, which is the Input Parameter 3 of the TMR UPIU.
> I am not sure why the author gave hba->nutrs + req->tag as the Task Tag
> of one TMR, the commit msg abot this part is not quite informative....
>
> Table 10.22 — Task Management Request UPIU
> TASK MANAGEMENT REQUEST UPIU
> ----------------------------------
> |0 |1 |2 |3 |
> ----------------------------------
> |xx00 0100b| Flags |LUN |Task Tag|
> ----------------------------------
> ...
> 16 (MSB) |17 |18 |19 (LSB)|
> ----------------------------------
> Input Parameter 2
> ----------------------------------
>
> Table 10.24 — Task Management Input Parameters
> Field Description
> Input Parameter 2 LSB: Task Tag of the task/command operated by the task
> management function.
Thanks for the clarification. Feel free to add the following to this patch:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
prev parent reply other threads:[~2021-02-07 2:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1611807365-35513-1-git-send-email-cang@codeaurora.org>
2021-01-28 4:16 ` [PATCH v3 1/3] scsi: ufs: Fix task management request completion timeout Can Guo
2021-01-29 3:22 ` Bart Van Assche
2021-01-29 5:46 ` Can Guo
2021-01-28 4:16 ` [PATCH v3 2/3] scsi: ufs: Fix a race condition btw task management request send and compl Can Guo
2021-01-29 3:20 ` Bart Van Assche
2021-01-29 6:06 ` Can Guo
2021-01-29 6:29 ` Can Guo
2021-02-01 2:27 ` Bart Van Assche
2021-01-28 4:16 ` [PATCH v3 3/3] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs Can Guo
2021-01-29 3:15 ` Bart Van Assche
2021-01-29 5:57 ` Can Guo
2021-02-01 2:39 ` Bart Van Assche
2021-02-05 6:09 ` Can Guo
2021-02-07 2:50 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00ae0fb0-4c35-686b-857c-b6cba40be83a@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=stanley.chu@mediatek.com \
--cc=sthumma@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®