From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756520AbcANRaA (ORCPT <rfc822;w@1wt.eu>);
	Thu, 14 Jan 2016 12:30:00 -0500
Received: from mailout4.w1.samsung.com ([210.118.77.14]:29047 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756346AbcANRZa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 14 Jan 2016 12:25:30 -0500
X-AuditID: cbfec7f4-f79026d00000418a-4a-5697da07ecf3
From: Kamil Debski <k.debski@samsung.com>
To: "'Wu-Cheng Li'" <wuchengli@chromium.org>, pawel@osciak.com,
        mchehab@osg.samsung.com, hverkuil@xs4all.nl, crope@iki.fi,
        standby24x7@gmail.com, nicolas.dufresne@collabora.com,
        ricardo.ribalda@gmail.com, ao2@ao2.it, bparrot@ti.com,
        kyungmin.park@samsung.com, jtp.park@samsung.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        tiffany.lin@mediatek.com, djkurtz@chromium.org
References: <1452783007-80883-1-git-send-email-wuchengli@chromium.org>
 <1452783007-80883-3-git-send-email-wuchengli@chromium.org>
In-reply-to: <1452783007-80883-3-git-send-email-wuchengli@chromium.org>
Subject: RE: [PATCH v3 2/2] s5p-mfc: add the support of
 V4L2_CID_MPEG_VIDEO_FORCE_I_FRAME.
Date: Thu, 14 Jan 2016 18:25:26 +0100
Message-id: <00b301d14ef0$8f51df00$adf59d00$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-index: AQKpCOES+EMx0+qWneMYpPzQkSDlQQIGrGq9nTtu75A=
Content-language: pl
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsVy+t/xK7rst6aHGRyZI2HRM7OB0eJbfyuL
	xffm92wWjTPms1qcmvyMyeLI2qtMFmeb3rBbbP7ewWax6fE1VovLu+awWfRs2MpqsfpZhcWu
	L/fYLKa8/clu0dU9j8ni0ozr7Batp+YwW5zpPsvkIOTRemcHm8fshossHjvuLmH02DnrLrvH
	4a8LWTw2L6n3aDm5n8Xj8a+XbB5b+oHifVtWMXocv7GdyePzJjmPU18/swfwRnHZpKTmZJal
	FunbJXBl7Hq+nLFgkkBF58VXLA2Mh3i7GDk5JARMJFY82M4MYYtJXLi3nq2LkYtDSGApo8ST
	09+ZIJzPjBLz5oNUcXCwCWhKrLrnARIXEZjHJPH2UycjSDezwCZGiUd7XSEamhklGpauYgNJ
	cAq4S6yZMROsSFggRmLRp8XsIDaLgKrEk913wGp4BSwl9vWuZIewBSV+TL7HAjFUS2L9zuNM
	ELa8xOY1b6FOVZDYcfY12EwRASuJtktPoOpFJO42PGedwCg0C8moWUhGzUIyahaSlgWMLKsY
	RVNLkwuKk9JzDfWKE3OLS/PS9ZLzczcxQmL9yw7GxcesDjEKcDAq8fD+uDstTIg1say4MvcQ
	owQHs5II78aD08OEeFMSK6tSi/Lji0pzUosPMUpzsCiJ887d9T5ESCA9sSQ1OzW1ILUIJsvE
	wSnVwOjwUr8gbcmp3Nd7c7+IdBh+myczR/nybKHw9WcN+46Gn5NUbNJSYD6V/c5/L1uJw327
	OaKVXFs4qq/OmC9jm/5njcZEs6/dIgYbJk8+tze6OcAg9aKCIFtQsZywSM3cPQxcq13aVczb
	kh/mnrthLpStZzX1d5KOx7LMR1uDJyb2J0cZHnTgUGIpzkg01GIuKk4EANjF7AjxAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> From: Wu-Cheng Li [mailto:wuchengli@chromium.org]
> Sent: Thursday, January 14, 2016 3:50 PM
> To: pawel@osciak.com; mchehab@osg.samsung.com; hverkuil@xs4all.nl;
> k.debski@samsung.com; crope@iki.fi; standby24x7@gmail.com;
> wuchengli@chromium.org; nicolas.dufresne@collabora.com;
> ricardo.ribalda@gmail.com; ao2@ao2.it; bparrot@ti.com;
> kyungmin.park@samsung.com; jtp.park@samsung.com
> Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> api@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> tiffany.lin@mediatek.com; djkurtz@chromium.org
> Subject: [PATCH v3 2/2] s5p-mfc: add the support of
> V4L2_CID_MPEG_VIDEO_FORCE_I_FRAME.

However simple the patch is, please do provide a commit message.
Please write something. 

Best wishes,
Kamil

> Signed-off-by: Wu-Cheng Li <wuchengli@chromium.org>
> ---
>  drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> index 0434f02..974b4c5 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> @@ -212,6 +212,14 @@ static struct mfc_control controls[] = {
>  		.menu_skip_mask = 0,
>  	},
>  	{
> +		.id = V4L2_CID_MPEG_VIDEO_FORCE_I_FRAME,
> +		.type = V4L2_CTRL_TYPE_BUTTON,
> +		.minimum = 0,
> +		.maximum = 0,
> +		.step = 0,
> +		.default_value = 0,
> +	},
> +	{
>  		.id = V4L2_CID_MPEG_VIDEO_VBV_SIZE,
>  		.type = V4L2_CTRL_TYPE_INTEGER,
>  		.minimum = 0,
> @@ -1423,6 +1431,10 @@ static int s5p_mfc_enc_s_ctrl(struct v4l2_ctrl
*ctrl)
>  	case V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE:
>  		ctx->force_frame_type = ctrl->val;
>  		break;
> +	case V4L2_CID_MPEG_VIDEO_FORCE_I_FRAME:
> +		ctx->force_frame_type =
> +
> 	V4L2_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE_I_FRAME;
> +		break;
>  	case V4L2_CID_MPEG_VIDEO_VBV_SIZE:
>  		p->vbv_size = ctrl->val;
>  		break;
> --
> 2.6.0.rc2.230.g3dd15c0