From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753429AbcBVFeT (ORCPT ); Mon, 22 Feb 2016 00:34:19 -0500 Received: from out114-135.biz.mail.alibaba.com ([205.204.114.135]:42563 "EHLO out11.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751345AbcBVFeS (ORCPT ); Mon, 22 Feb 2016 00:34:18 -0500 X-Greylist: delayed 1009 seconds by postgrey-1.27 at vger.kernel.org; Mon, 22 Feb 2016 00:34:17 EST X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R771e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01l04364;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_----4Xk-vWr_1456118202; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "'Mike Galbraith'" Cc: "'Sebastian Andrzej Siewior'" , "'Thomas Gleixner'" , "'LKML'" , "'linux-rt-users'" References: <00a501d16d22$30045140$900cf3c0$@alibaba-inc.com> <1456113785.3706.5.camel@gmail.com> In-Reply-To: <1456113785.3706.5.camel@gmail.com> Subject: Re: [patch] sched,rt: __always_inline preemptible_lazy() Date: Mon, 22 Feb 2016 13:16:42 +0800 Message-ID: <00b501d16d30$394e0fd0$abea2f70$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJD7p6qDhZOyZwp4BItfDqNizeLyAI+z9munkCAS7A= Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > sched,rt: __always_inline preemptible_lazy() > > Functions called within a notrace function must either also be > notrace or be inlined, lest recursion blow the stack. > > homer: # nm kernel/sched/core.o|grep preemptible_lazy > 00000000000000b5 t preemptible_lazy > > echo wakeup_rt > current_tracer ==> Welcome to infinity. > > Signed-off-by: Mike Galbraith > --- Thank you, Mike. Acked-by: Hillf Danton > kernel/sched/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -3469,7 +3469,7 @@ static void __sched notrace preempt_sche > * set by a RT task. Oterwise we try to avoid beeing scheduled out as long as > * preempt_lazy_count counter >0. > */ > -static int preemptible_lazy(void) > +static __always_inline int preemptible_lazy(void) > { > if (test_thread_flag(TIF_NEED_RESCHED)) > return 1;