mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael Kerrisk" <mtk-lists@jambit.com>
To: "Oleg Drokin" <green@linuxhacker.ru>,
	"Michael Kerrisk" <mtk-lists@jambit.com>
Cc: <linux-kernel@vger.kernel.org>,
	"Hans Reiser" <reiser@namesys.com>,
	"Vladimir Saveliev" <vs@namesys.com>,
	"Chris Mason" <mason@suse.com>, "mk" <michael.kerrisk@gmx.net>
Subject: Re: Strange NOTAIL inheritance behaviour in Reiserfs 3.6
Date: Thu, 24 Jun 2004 18:11:18 +0200	[thread overview]
Message-ID: <00b801c45a05$e22be3c0$c100a8c0@wakatipu> (raw)
In-Reply-To: <20040624155840.GG2362@linuxhacker.ru>

> On Thu, Jun 24, 2004 at 04:27:44PM +0200, Michael Kerrisk wrote:
> > >
> > > MK>     # mount -t reiserfs /dev/hda12 /testfs
> > > Does it work as expected if you add "-o attrs" to the mount command?
> > Yes!  Thanks.  However, it is a little unfortunate that if one fails
> > to use this option, then:
> > 1. "chattr +t" (and I suppose underlying ioctl()s) can still be used to
> >    set this attribute on a directory, without any error resulting.
> >    It would be better if an error is reported.
>
> Well, initial idea was to allow people to at least reset attributes
> in case of operationg with disabled attributes processing.

This seems to a bad idea.  Why should I be able to reset
attributes if the FS is mounted without "-o attrs"?  That
seems to thwart the point of excluding "-o attrs".  In any
case, how about at least an error when one tries to *set*
attributes when "-o attrs" was specified?

> > 2. The attribute is then inherited by files created in that directory,
> >    but has no effect.
>
> Yes, attribute inheritance is working. The only part that is disabled
> by default is copying from fs-specific attribute storage to actual VFS
inode
> attributes.
>
> > 3. A later explicit "chattr + t" on the files themselves DOES result in
> >    unpacking of the tails.  Why?
>
> There is a check in attributes setting code (and attributes
setting/cleaning
> is enabled), that tests if NOTAIL attribute is set, that calls tails
> unpacking if so. Next time you write to that file it will be packed back
> (if possible).

Strange ;-).

> I agree that all of this is not very intuitive, though.

Okay -- thanks Oleg.

Cheers,

Michael


      reply	other threads:[~2004-06-24 16:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-22 16:21 Michael Kerrisk
2004-06-22 21:30 ` Hans Reiser
2004-06-23 11:11 ` Oleg Drokin
     [not found]   ` <005e01c459f7$6a8546d0$c100a8c0@wakatipu>
2004-06-24 15:58     ` Oleg Drokin
2004-06-24 16:11       ` Michael Kerrisk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00b801c45a05$e22be3c0$c100a8c0@wakatipu' \
    --to=mtk-lists@jambit.com \
    --cc=green@linuxhacker.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@suse.com \
    --cc=michael.kerrisk@gmx.net \
    --cc=reiser@namesys.com \
    --cc=vs@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®