mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Jens Axboe <axboe@kernel.dk>,
	Li Lingfeng <lilingfeng@huaweicloud.com>,
	allison.karlitskaya@redhat.com, hch@infradead.org,
	yukuai1@huaweicloud.com
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	houtao1@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] block: Move checking GENHD_FL_NO_PART to bdev_add_partition()
Date: Fri, 19 Jan 2024 09:27:34 +0800	[thread overview]
Message-ID: <00c59648-bbf3-7ae4-4cea-aeccbb2bfe0c@huaweicloud.com> (raw)
In-Reply-To: <f6e687cc-debd-4864-901a-fb35be9f2adc@kernel.dk>

Hi,

在 2024/01/18 23:20, Jens Axboe 写道:
> On 1/18/24 6:04 AM, Li Lingfeng wrote:
>> From: Li Lingfeng <lilingfeng3@huawei.com>
>>
>> Commit 1a721de8489f ("block: don't add or resize partition on the disk
>> with GENHD_FL_NO_PART") prevented all operations about partitions on disks
>> with GENHD_FL_NO_PART in blkpg_do_ioctl() since they are meaningless.
>> However, it changed error code in some scenarios. So move checking
>> GENHD_FL_NO_PART to bdev_add_partition() to eliminate impact.
> 
> This looks fine, but it's identical to the one sent out by Yu two days
> ago. Hmm? Who's the proper author?

Lingfeng is my collegue and I told him that he should send a fix for his
formal patch. Sorry for the confusion :)

Reviewed-by: Yu Kuai <yukuai3@huawei.com>

> 
> Adding Yu.
> 


  reply	other threads:[~2024-01-19  1:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 13:04 Li Lingfeng
2024-01-18 15:20 ` Jens Axboe
2024-01-19  1:27   ` Yu Kuai [this message]
2024-01-20  1:08 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00c59648-bbf3-7ae4-4cea-aeccbb2bfe0c@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=allison.karlitskaya@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=houtao1@huawei.com \
    --cc=lilingfeng@huaweicloud.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®