From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 655863D5679 for ; Mon, 8 Jun 2026 17:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780938644; cv=none; b=FU7YzRq+URTPb1IneNhtomXZQq32nGL1soTmS/EkBUeh13gVAu12Ixl+O7Cq5MbPbjai1VielEa1zZfFmgKXqLn+RffhV3LCrZ2RaOVObVi5HFAMoDtszoOnlrkGOLifNZPRAyfcrCwQPM5OKFQaoyKwiI/z1CE2yhc3x6SoPec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780938644; c=relaxed/simple; bh=1jvziielmBQRhjbGDR1LkdWpDfix4f9jfDw9HyW1EWo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=iYgrsbFeobxfoDHjHik5sAHUmEg9MalU/+93NX5x9Cr7jO5XPv6iKQ/aQGy3HcULeA+GTOmvc2RSzHFiN68GaCY3dXLDM+yG9qqGkJHFXLYZ13O8exJwGcO5VcWI859fp9/9cDTwVzQ9e7fdmr2TjkjB2hH3vKga9ZX1RrHzO/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NvXzn9jZ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=HlkKJ29q; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NvXzn9jZ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="HlkKJ29q" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780938639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1jvziielmBQRhjbGDR1LkdWpDfix4f9jfDw9HyW1EWo=; b=NvXzn9jZ7e8p3N3tmD0BAYDlWrfrnsrqbnAGl4mPVBFdMS5tNEk+d/Lsbcs1ejGMTxCJiH l2KWRF+vTaHdXrC+aeWFj9USLDf0LiMd3gKpDR71RltuBfe0idXc5t9sqzyQW5ePWSg4bP OQ9Emi0hpwtW7uf1/bcs0ICM2bmbKPE= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-364-wB9y-HaQP3qd8yHtxmt3DQ-1; Mon, 08 Jun 2026 13:10:22 -0400 X-MC-Unique: wB9y-HaQP3qd8yHtxmt3DQ-1 X-Mimecast-MFC-AGG-ID: wB9y-HaQP3qd8yHtxmt3DQ_1780938621 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-915757be497so858062185a.2 for ; Mon, 08 Jun 2026 10:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780938621; x=1781543421; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=1jvziielmBQRhjbGDR1LkdWpDfix4f9jfDw9HyW1EWo=; b=HlkKJ29q2A8tjBwFEKInSrLU4JNL5yF3vcXg19nomGqbgzRPcFGwPmCIpqkQrsglgo WmBjYdi/3Ja+ropRt5B5tzOxJ8TXVRKwb08IcCdpI42cnBpT2Yr+apjILs+8ctPLKHqm RZ/4pW9YxpgQ/XV4nc5z6gjChqN1ju6tnYVLqpXG7pugnN8iQpep/YksXwiwGrX8sVht ogH9/XEw3/uVx4RGqgO5bDpbzo88PgrdYUY1pRUbSB73uqj2+BdjYMFbIX9ZRPLpe998 N5bUnuKbioHTK8Qp3HSfkYoYlLE9zUqFCnknANFJ+0bfQxX7z2gGnjuj+q3qv+YAQweN bHGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780938621; x=1781543421; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1jvziielmBQRhjbGDR1LkdWpDfix4f9jfDw9HyW1EWo=; b=rgC0sYvyEU1te7kBzZyEgo7BODy5zEixNtIYrdt7/TVbF+ojQKDGaqtdKD+NcsgaJ4 Qo9VJYPKm7VcOD1z44n7pLe8Y9o/G0Yrzs1yoFI2GQ6mtY1qEO3u2PoMiHOkB5yXM01m gWM0KndZ39RiOasYDehZ8LkUwAlrevMxcKvqJmdEVZXoRbpZm8ZZP+LNoeCg436FfqnI EQ7on4dLVsTNBnP6JRfwIqkqbH69iH0mvFENjXDi0MdCaEdEl1L8SzcxEGyRTaSwQpF2 Lq0uMpQk+F7cL7GJ9fmScNykrzwtl0YI+tPj2nCv71BUpKfusG2j8IbS8nNjI1GFW+KT P48w== X-Forwarded-Encrypted: i=1; AFNElJ9SeMyWTSglB2CozP0lf532wHXzH4efzCaDYU3EIGi5VyDfuRc8NmGPSbEeKixD62a96SfgWEpMuFD5d8k=@vger.kernel.org X-Gm-Message-State: AOJu0YzF8SOnSv7bqktndg5TXH0Day0Ds4yBDzjSENWCiTBvWIlSNU6Y RC4GQxrxJkHZk+egkWYmbpVUiy/H4HLAJC+q0ic+yKe97+Um3HA2aX7JswnTUAf/XO/PRmPVW0o FLeP1ixDXRgvF0zSqLgRn1hcjP6DX68WUxF0j0xeuTu1Q8G/VmulKW2iQqIYex731Xg== X-Gm-Gg: Acq92OFC0yy2CesyUghv8fhkBl5ai9IAemDoKYYJM7e70wjCzPVmkMCo4dMI8rS1bKC tp3JbYuDoSutizSHYVdVaXK0W/kt5PjcpwbwReg9oNg3kTuXSJULQJFiMtxBDxWlusAljV95B15 MLfEOcIx9xVPZWzaNFJxPcQoIdnHbv9sfrMk+8Lp2qo7wyMBfRj+czeBA9vsI11SfsWeHZDMEkM Yo6u3541b0htae1ByPSaKnsjErDkZcmSloluDrF60XIJx8JCqQM+6c8+ZMbfMsaj/OBj9g6euJp F//5XTZHQu7jkeV9DqDBdKiiDs4h/HY432/3GBUr+HU8rYOhKGtInkTe45FLhjETvSyLL9bLbQg 9UW1ahMj3nHoBEMvVWUxPjCqVHS/i X-Received: by 2002:a05:620a:254a:b0:915:9943:d760 with SMTP id af79cd13be357-915a9db892dmr2520125585a.43.1780938621260; Mon, 08 Jun 2026 10:10:21 -0700 (PDT) X-Received: by 2002:a05:620a:254a:b0:915:9943:d760 with SMTP id af79cd13be357-915a9db892dmr2520115285a.43.1780938620617; Mon, 08 Jun 2026 10:10:20 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a3bf5f9sm1822479085a.35.2026.06.08.10.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 10:10:19 -0700 (PDT) Message-ID: <00c7a09eac169e9da541b50396ceaa69ae978c10.camel@redhat.com> Subject: Re: [PATCH v18 1/4] rust: drm: gem: shmem: Add DmaResvGuard helper From: lyude@redhat.com To: Gary Guo , dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, nouveau@lists.freedesktop.org Cc: Alexandre Courbot , Christian =?ISO-8859-1?Q?K=F6nig?= , driver-core@lists.linux.dev, Miguel Ojeda , Maarten Lankhorst , Alice Ryhl , Simona Vetter , linux-kernel@vger.kernel.org, Sumit Semwal , linux-media@vger.kernel.org, "Rafael J . Wysocki" , Thomas Zimmermann , Maxime Ripard , David Airlie , Benno Lossin , linaro-mm-sig@lists.linaro.org, Danilo Krummrich , Mukesh Kumar Chaurasiya , Asahi Lina , Daniel Almeida , Greg Kroah-Hartman Date: Mon, 08 Jun 2026 13:10:18 -0400 In-Reply-To: References: <20260604192740.659240-1-lyude@redhat.com> <20260604192740.659240-2-lyude@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 I think I have just been defaulting to always for anything that seems like it should be unquestionably inlined - should I be defaulting to #[inline] instead? On Sun, 2026-06-07 at 13:22 +0100, Gary Guo wrote: > > +impl<'a, T: DriverObject, C: DeviceContext> DmaResvGuard<'a, T, C> > > { > > +=C2=A0=C2=A0=C2=A0 #[inline(always)] >=20 > Why `always` here? >=20 > Best, > Gary