From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754655AbcEQOUr (ORCPT ); Tue, 17 May 2016 10:20:47 -0400 Received: from emcscan.emc.com.tw ([192.72.220.5]:33369 "EHLO emcscan.emc.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbcEQOUq convert rfc822-to-8bit (ORCPT ); Tue, 17 May 2016 10:20:46 -0400 From: =?UTF-8?B?5buW5bSH5qau?= To: "'Dmitry Torokhov'" Cc: , , , =?UTF-8?B?J+m7g+S4lum1rCDntpPnkIYn?= , "'Charles Mooney'" , "'Agnes Cheng'" , "'jeff'" References: <006901d1acea$8207d090$861771b0$@emc.com.tw> <00be01d1af65$ec37c290$c4a747b0$@emc.com.tw> <20160516175342.GD12752@dtor-ws> In-Reply-To: <20160516175342.GD12752@dtor-ws> Subject: RE: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger Date: Tue, 17 May 2016 22:20:40 +0800 Message-ID: <00c901d1b047$4a2d3ba0$de87b2e0$@emc.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 thread-index: AQJlpFtre/R/19XiZrouR3fFhL59vQGLjSU7Aq0kxD4B4uxK+J5kZNlA Content-Language: zh-tw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, I want to confirm my thought for your idea to avoid misunderstanding. I think you want to encapsulate " BTN_TOOL_FINGER" in the [input_mt_report_pointer_emulation] if hover happen. Vendor driver only report "ABS_DISTANCE" and let [input_mt_report_pointer_emulation] emit BTN_TOOL_FINGER report without change function parameter. Please let me know if my misunderstand about your idea. Thanks KT -----Original Message----- From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com] Sent: Tuesday, May 17, 2016 1:54 AM To: 廖崇榮 Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; zac.hsieh@emc.com.tw; 黃世鵬 經理; 'Charles Mooney'; 'Agnes Cheng' Subject: Re: [PATCH] Input: Change BTN_TOOL_FINGER flag when hover event trigger Hi Kt, On Mon, May 16, 2016 at 07:27:25PM +0800, 廖崇榮 wrote: > > Only ABS_DISTANCE is not enough for upper OS to distingiush hover > event be triggered from object from faraway to and close touchpad > surface or from object prepare to leave the touchpad surface. Add > BTN_TOOL_FINGER flag to help it. > > object_from_faraway object_inside_hover_area > object_touch_surface > BTN_TOUCH 0 0 1 > BTN_TOOL_FINGER 0 1 1 > ABS_DISTANCE 0 1 0 > > Signed-off by: Duson Lin I was wondering if we could do without modifying all the drivers that are using input_mt_report_pointer_emulation(), by figuring out if we should be emitting BTN_TOOL_FINGER right there: "If device supports ABS_DISTANCE and does not support ABS_MT_DISTANCE and ABS_DISTANCE != 0 is reported in current frame and there are no other contacts then report BTN_TOOL_FINGER." Thanks. -- Dmitry