From: Benno Lossin <benno.lossin@proton.me>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "kernel test robot" <lkp@intel.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
"Greg KH" <greg@kroah.com>,
"Simona Vetter" <simona.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 1/2] rust: add untrusted data abstraction
Date: Fri, 27 Sep 2024 09:06:45 +0000 [thread overview]
Message-ID: <00ca48e4-1b4a-496d-a06b-3c12a9ef2d14@proton.me> (raw)
In-Reply-To: <CANiq72=-bV_=TUoH6gLnPwTcxROBqyrCpOpbumki_S+po1TPhQ@mail.gmail.com>
On 27.09.24 10:39, Miguel Ojeda wrote:
> On Fri, Sep 27, 2024 at 12:15 AM Benno Lossin <benno.lossin@proton.me> wrote:
>>
>> Personally, I would prefer adding a symbol. Since if we allow it, then
>> it might take a long time until the code is removed once we increase the
>> minimum version.
>>
>> It would be best, if it produces an error when we raise the minimum
>> version beyond the one represented by the symbol. Is that already the
>> case?
>
> No -- that is a nice idea that I guess could be implemented in Kconfig
> somewhere (i.e. when checking conditions). However, one of the common
> things to do when upgrading the minimum is to review/clean the
> `*_VERSION` uses anyway (and they may occur outside Kconfig files
> too), and also sometimes one wants to upgrade a minimum without doing
> the cleanups immediately (e.g. the recently proposed GCC 8.1 upgrade).
>
>> Gave it a try and I also can't reproduce the error there...
>
> Hmm... I think CE uses the Rust-provided binaries (and I guess the
> playground too). Do you have a link ("Share" in CE)?
Here you go: https://godbolt.org/z/qE8E9M56c
The error that I get locally:
error: unreachable pattern
--> src/main.rs:8:9
|
8 | Err(e) => match e {},
| ^^^^^^ matches no values because `Infallible` is uninhabited
|
= note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types
note: the lint level is defined here
--> src/main.rs:1:9
|
1 | #![deny(unreachable_patterns)]
| ^^^^^^^^^^^^^^^^^^^^
error: could not compile `rust` (bin "rust") due to 1 previous error
---
Cheers,
Benno
next prev parent reply other threads:[~2024-09-27 9:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240925205244.873020-1-benno.lossin@proton.me>
2024-09-25 20:53 ` Benno Lossin
2024-09-26 7:08 ` Dirk Behme
2024-09-26 10:40 ` Simona Vetter
2024-09-30 14:04 ` Benno Lossin
2024-11-26 8:05 ` Simona Vetter
2024-09-26 20:31 ` kernel test robot
2024-09-26 21:40 ` Benno Lossin
2024-09-26 21:56 ` Miguel Ojeda
2024-09-26 22:15 ` Benno Lossin
2024-09-27 8:39 ` Miguel Ojeda
2024-09-27 9:06 ` Benno Lossin [this message]
2024-09-26 21:57 ` Miguel Ojeda
2024-09-25 20:53 ` [PATCH v2 2/2] rust: switch uaccess to untrusted data API Benno Lossin
2024-09-26 11:09 ` Simona Vetter
2024-09-26 23:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00ca48e4-1b4a-496d-a06b-3c12a9ef2d14@proton.me \
--to=benno.lossin@proton.me \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona.vetter@ffwll.ch \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®