From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B279BC04ABB for ; Thu, 13 Sep 2018 15:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 719E6206B6 for ; Thu, 13 Sep 2018 15:17:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 719E6206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728303AbeIMU0z (ORCPT ); Thu, 13 Sep 2018 16:26:55 -0400 Received: from foss.arm.com ([217.140.101.70]:49968 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726824AbeIMU0z (ORCPT ); Thu, 13 Sep 2018 16:26:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1562F7A9; Thu, 13 Sep 2018 08:16:58 -0700 (PDT) Received: from [10.4.12.116] (e107155-lin.emea.arm.com [10.4.12.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 097AA3F557; Thu, 13 Sep 2018 08:16:55 -0700 (PDT) Cc: Sudeep Holla , Jeffrey Hugo , Jeremy Linton , rjw@rjwysocki.net, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, vkilari@codeaurora.org Subject: Re: [PATCH] ACPI/PPTT: Handle architecturally unknown cache types To: Brice Goglin , James Morse References: <1536694334-5811-1-git-send-email-jhugo@codeaurora.org> <4f253bf4-ef2d-849f-b793-9b0530e72aab@gmail.com> <20180913103525.GA7777@e107155-lin> <0f23136a-cfb7-8def-702a-87e02705f0d6@gmail.com> From: Sudeep Holla Organization: ARM Message-ID: <00cadeff-3a1c-c780-2641-04e47c26181f@arm.com> Date: Thu, 13 Sep 2018 16:16:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <0f23136a-cfb7-8def-702a-87e02705f0d6@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/09/18 12:53, Brice Goglin wrote: > Le 13/09/2018 à 11:35, Sudeep Holla a écrit : >>> On 13/09/18 06:51, Brice Goglin wrote: [...] >>>> By the way, did anybody actually see an error with lstopo when there's >>>> no "type" attribute for L3? I can't reproduce any issue, we just skip >>>> that specific cache entirely, but everything else appears. If you guys >>>> want to make that "no_cache" cache appear, I'll make it a Unified cache >>>> unless you tell me what to show :) >> IIUC, Jeffrey Hugo did see error as per his initial message: >> " >> This fixes the following lscpu issue where only the cache type sysfs file >> is missing which results in no output providing a poor user experience in >> the above system configuration. >> lscpu: cannot open /sys/devices/system/cpu/cpu0/cache/index3/type: No such >> file or directory >> " >> > > I don't know about lscpu (it's a different project), but lstopo > shouldn't have any such problem. > Ah OK, I have only looked at lscpu source. Sorry for that, I assumed they are based on same/similar code base. Thanks for letting me know they are not. > If you see an issue with lstopo, I'd be interesting in getting the > tarball generated by hwloc-gather-topology (it dumps useful files from > procfs and sysfs so that we may debug offline). Thanks for the information. -- Regards, Sudeep