From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753294AbbL2JTR (ORCPT ); Tue, 29 Dec 2015 04:19:17 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:55112 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbbL2JTM (ORCPT ); Tue, 29 Dec 2015 04:19:12 -0500 X-AuditID: cbfee61b-f793c6d00000236c-c8-5682500e3b69 From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <1451345497-65784-1-git-send-email-jaegeuk@kernel.org> <1451345497-65784-2-git-send-email-jaegeuk@kernel.org> In-reply-to: <1451345497-65784-2-git-send-email-jaegeuk@kernel.org> Subject: RE: [f2fs-dev] [PATCH 2/3] f2fs: use i_size_read to get i_size Date: Tue, 29 Dec 2015 17:18:19 +0800 Message-id: <00cd01d14219$f6d317e0$e47947a0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQF8sL4YKOhQKJAKtMQkmbtvwkRILwIJUJ7Kn3qGdTA= Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t9jQV2+gKYwg61vZCyerJ/FbHFpkbvF nr0nWSwu75rD5sDisWlVJ5vH7gWfmTw+b5ILYI7isklJzcksSy3St0vgyjjydwpTwVGeis2L d7E1MG7h6mLk4JAQMJF4Nrusi5ETyBSTuHBvPVsXIxeHkMAsRon/p6eyQjivGCX+7d/IDFLF JqAisbzjPxOILSKgJtG7bwqYzSyQKTGh/wU7iC0kUC3x+kA/G4jNKeAssWLWFlYQW1jAXeLM o4dg9SwCqhKXdnWDxXkFLCUeXFzPCGELSvyYfI8FYqaWxPqdx6Hmy0tsXvOWGeJSBYkdZ18z QtxgJbF59WRGiBpxiY1HbrFMYBSahWTULCSjZiEZNQtJywJGllWMEqkFyQXFSem5Rnmp5XrF ibnFpXnpesn5uZsYweH/THoH4+Fd7ocYBTgYlXh4MyY1hgmxJpYVV+YeYpTgYFYS4XXdAhTi TUmsrEotyo8vKs1JLT7EKM3BoiTOu+9SZJiQQHpiSWp2ampBahFMlomDU6qB8ZDyh7/OmYnH Hu85LClS/3rH0V2r3/18xxBQpdHN8NPixZ1bhblrDSetLwp6Iuz9cW10v9qmHRrbC33EFv4N YD3WZ96p/Of1pxPOv90v/WBf+4XzVtxrh9CD3btWFrzf5c104qg9c2Cq082Wp1WbtxdMyHuh PpPt275tBzYvLDxUpVvTG8P3+ZsSS3FGoqEWc1FxIgBwumLrewIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Tuesday, December 29, 2015 7:32 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 2/3] f2fs: use i_size_read to get i_size > > We need to use i_size_read() to get inode->i_size. All callers of f2fs_write_failed should be protected by i_mutex, so no one can change i_size, do we really need to use i_size_read here? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/data.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index f34f42a..8a89810 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1386,10 +1386,11 @@ skip_write: > static void f2fs_write_failed(struct address_space *mapping, loff_t to) > { > struct inode *inode = mapping->host; > + loff_t i_size = i_size_read(inode); > > - if (to > inode->i_size) { > - truncate_pagecache(inode, inode->i_size); > - truncate_blocks(inode, inode->i_size, true); > + if (to > i_size) { > + truncate_pagecache(inode, i_size); > + truncate_blocks(inode, i_size, true); > } > } > > -- > 2.5.4 (Apple Git-61) > > > ------------------------------------------------------------------------------ > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel