From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759072AbbJ3KvL (ORCPT ); Fri, 30 Oct 2015 06:51:11 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:55542 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758636AbbJ3KvJ convert rfc822-to-8bit (ORCPT ); Fri, 30 Oct 2015 06:51:09 -0400 X-AuditID: cbfec7f5-f794b6d000001495-33-56334b9a81ee From: Pavel Fedin To: "'Pankaj Dubey'" Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "'linux-samsung-soc'" , linux-kernel@vger.kernel.org, "'Rob Herring'" , "'Pawel Moll'" , "'Mark Rutland'" , "'Ian Campbell'" , "'Kumar Gala'" , "'Kukjin Kim'" , "'Krzysztof Kozlowski'" References: <009f01d112dd$fab40830$f01c1890$@samsung.com> <56333731.1000400@samsung.com> In-reply-to: <56333731.1000400@samsung.com> Subject: RE: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410 Date: Fri, 30 Oct 2015 13:51:03 +0300 Message-id: <00d501d11300$e0b4fb60$a21ef220$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Thread-index: AQG1Qj+spkOVIgDiU4jMHmu53IoLAgIbXF5mAeYez/wBU+gBigI3lmKSnn8HLTA= Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsVy+t/xK7qzvI3DDPomCVrMP3KO1aL/zUJW i3OvVjJavH5haNH/+DWzxabH11gtLu+aw2Yx4/w+Joul1y8yWSza+oXdYsL0tSwWrXuPsDvw eKyZt4bR43JfL5PHyuVf2Dw2repk89i8pN6jb8sqRo/Pm+QC2KO4bFJSczLLUov07RK4Mt60 bGAvuC5SMe/2PfYGxsv8XYycHBICJhKLLhxghLDFJC7cW8/WxcjFISSwlFHi+8657BDOd0aJ a8sXs4JUsQmoS5z++oEFxBYR0JWY9egNM0gRs8AeZonuFaeg2ucwSbw9vYgNpIpTQFvi2J4d YLawgJ3EivbFYN0sAqoSfzefYgKxeQUsJV4d6GeFsAUlfky+B1TDATRVXWLKlFyQMDPQmCfv LrBCnKogsePsa0aII/wkDjd9ZYSoEZGY9u8e8wRGoVlIJs1CmDQLyaRZSDoWMLKsYhRNLU0u KE5KzzXSK07MLS7NS9dLzs/dxAiJuK87GJceszrEKMDBqMTD+yPBKEyINbGsuDL3EKMEB7OS CG+Pk3GYEG9KYmVValF+fFFpTmrxIUZpDhYlcd6Zu96HCAmkJ5akZqemFqQWwWSZODilGhg1 roruLmj7KuWwR7fp3YZgV+t016Wh7M99X7E/cNSVnFXesftRtYPa76Sb98szOA8cXWfssp+H t7Ca5f3WD3e7E8rvWlqfY5xs/Ddmc4XTehmO5XfUDj+L4joxW0r8zBN7fonaov+r17Y5L8+X c3aemPb579VAEbXzm7hyBXfdmhUw1+hQfZISS3FGoqEWc1FxIgD1sf+EtAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! > >>> + sromc: sromc@12250000 { > >>> + #address-cells = <1>; > >>> + #size-cells = <1>; > >>> + ranges; > >>> + > >> > >> We do not need to specify these three properties as they are already > >> present in parent node "soc". > > > > We do, otherwise dtc complains about defaults of #address-cells = 2 and #size-cells=1, and > without empty "ranges" subnode's resources are not correctly translated. > > > > First of all this patch will not give this error. So this part should > not be a part of this patch. > You should be getting above error after applying v4 4/4 "ARM: dts: Add > Ethernet chip to SMDK5410". So if its failing for ethernet subnode, you > can move this address-cells and size-cells in dts file just above > ethernet node as shown below: > > index 311e7be..d69981d 100644 > --- a/arch/arm/boot/dts/exynos5410-smdk5410.dts > +++ b/arch/arm/boot/dts/exynos5410-smdk5410.dts > @@ -95,6 +95,9 @@ > }; > > &sromc { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > pinctrl-names = "default"; > pinctrl-0 = <&srom_ctl>, <&srom_ebi>; > IMHO this makes little of sense, because in this case you would have to duplicate these properties for every supported machine. address-cells, size-cells and ranges belong to the controller itself, not to its children. Of course i could split up the patch into two, first introduce sromc, second introduce mapping. But does it worth that? Both patches would be 3 lines of code each. Anyway, this specific talk is outdated by now, please check out neighbor topic, we are discussing significantly improved binding with Krzystof. > And another question still remains open, we can't just like that change > "smsc,lan9115" binding by adding samsung specific properties. I am sorry, but you either do not understand us with Krzystof, or not reading at all... This is not a change in the binding. And these properties do not belong to smsc at all. They would be added to *ANY* device which sits on top of SROMc. This is more like a bus-specific extra. It's similar to "reg" property having different meanings for different buses. > Probably you can check suggestions from Krzysztof, where he pointed out > some hint on how other places this is getting used. Did you read them? I did, and they do exactly the same thing as i do. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia