From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932226AbcGCVI2 (ORCPT ); Sun, 3 Jul 2016 17:08:28 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:47507 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932156AbcGCVI1 (ORCPT ); Sun, 3 Jul 2016 17:08:27 -0400 X-ME-Helo: [127.0.0.1] X-ME-Date: Sun, 03 Jul 2016 23:08:24 +0200 X-ME-IP: 92.140.234.177 Subject: Re: [PATCH] phy: fix error handling To: kishon@ti.com, maxime.ripard@free-electrons.com, wens@csie.org References: <1467525332-12963-1-git-send-email-christophe.jaillet@wanadoo.fr> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Newsgroups: gmane.linux.kernel.janitors,gmane.linux.ports.arm.kernel,gmane.linux.kernel From: Christophe JAILLET Message-ID: <00d5243a-0359-1dc7-e9aa-1ad8a9074821@wanadoo.fr> Date: Sun, 3 Jul 2016 23:08:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1467525332-12963-1-git-send-email-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Antivirus: avast! (VPS 160703-1, 03/07/2016), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I will resubmit in the coming days. return PTR_ERR(phy->clk); should also be updated. Best regards, CJ Le 03/07/2016 à 07:55, Christophe JAILLET a écrit : > This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is > expected here. > > Signed-off-by: Christophe JAILLET > --- > drivers/phy/phy-sun9i-usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-sun9i-usb.c b/drivers/phy/phy-sun9i-usb.c > index ac4f31a..ff99eba 100644 > --- a/drivers/phy/phy-sun9i-usb.c > +++ b/drivers/phy/phy-sun9i-usb.c > @@ -141,7 +141,7 @@ static int sun9i_usb_phy_probe(struct platform_device *pdev) > } > > phy->hsic_clk = devm_clk_get(dev, "hsic_12M"); > - if (IS_ERR(phy->clk)) { > + if (IS_ERR(phy->hsic_clk)) { > dev_err(dev, "failed to get hsic_12M clock\n"); > return PTR_ERR(phy->clk); > }