mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
	"'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
	"'Tomasz Figa'" <tomasz.figa@gmail.com>,
	"'Chanwoo Choi'" <cw00.choi@samsung.com>,
	"'Michael Turquette'" <mturquette@baylibre.com>,
	"'Stephen Boyd'" <sboyd@kernel.org>,
	<linux-samsung-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: "'kernel test robot'" <lkp@intel.com>
Subject: RE: [PATCH] clk: samsung: fix missing Tesla FSD dependency on Exynos
Date: Sun, 30 Jan 2022 12:49:38 +0530	[thread overview]
Message-ID: <00d701d815a9$bf5cb590$3e1620b0$@samsung.com> (raw)
In-Reply-To: <20220129173407.278591-1-krzysztof.kozlowski@canonical.com>



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Saturday, January 29, 2022 11:04 PM
>To: Sylwester Nawrocki <s.nawrocki@samsung.com>; Tomasz Figa
><tomasz.figa@gmail.com>; Chanwoo Choi <cw00.choi@samsung.com>; Alim
>Akhtar <alim.akhtar@samsung.com>; Michael Turquette
><mturquette@baylibre.com>; Stephen Boyd <sboyd@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski@canonical.com>; linux-samsung-
>soc@vger.kernel.org; linux-clk@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Cc: kernel test robot <lkp@intel.com>
>Subject: [PATCH] clk: samsung: fix missing Tesla FSD dependency on Exynos
>
>The Tesla FSD clock controller driver uses shared parts from Exynos
>ARM64 clock drivers, so add proper dependency to fix COMPILE_TEST build
>errors like:
>
>  /usr/bin/aarch64-linux-gnu-ld: drivers/clk/samsung/clk-fsd.o: in function
>`fsd_cmu_probe':
>  clk-fsd.c:(.init.text+0x9c): undefined reference to
>`exynos_arm64_register_cmu'
>
>Reported-by: kernel test robot <lkp@intel.com>
>Fixes: e3f3dc3810d3 ("clk: samsung: fsd: Add cmu_peric block clock
>information")
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
Thanks Krzysztof for a quick patch 

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

> drivers/clk/samsung/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
index
>5f64c58f120f..8e8245ab3fd1 100644
>--- a/drivers/clk/samsung/Kconfig
>+++ b/drivers/clk/samsung/Kconfig
>@@ -129,6 +129,7 @@ config S3C2443_COMMON_CLK  config
>TESLA_FSD_COMMON_CLK
> 	bool "Tesla FSD clock controller support" if COMPILE_TEST
> 	depends on COMMON_CLK_SAMSUNG
>+	depends on EXYNOS_ARM64_COMMON_CLK
> 	help
> 	  Support for the clock controller present on the Tesla FSD SoC.
> 	  Choose Y here only if you build for this SoC.
>--
>2.32.0



  parent reply	other threads:[~2022-01-30  7:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220129173417epcas5p35f8f3497b6465c07c481b62ceeff0ef0@epcas5p3.samsung.com>
2022-01-29 17:34 ` Krzysztof Kozlowski
2022-01-29 18:00   ` Krzysztof Kozlowski
2022-01-30  7:19   ` Alim Akhtar [this message]
2022-02-01  8:16   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00d701d815a9$bf5cb590$3e1620b0$@samsung.com' \
    --to=alim.akhtar@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mturquette@baylibre.com \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®