From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5897A1EC013 for ; Thu, 7 Nov 2024 12:53:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730984014; cv=none; b=h9IhW79mUeM6ozv6AarvDwtP7e5X1+pEzk+uzy8Tj8EYU1sYu00VVa/9oDqQIBNpo6cGRmkpB8Yv3eHFVeRsOQhuQvE85YdunCn3eqEUMkoRbcD8KCPuO5F7m3LgYmj+2tQA1cyYZ5P8TfV2VUKg1eVlgZyatFsFicDAXtPYVNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730984014; c=relaxed/simple; bh=nHle/FoZRfApU/nMdNPchmKj4kafgyZgX9QQCY1i+p0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CPwTr8jsngzlMSp2an0z1JVDlPcqs9jMA1lSk9HRY3EBdbZLQBHGIjdqHqMsWbpdVyqxIu5870wPBBvCOawMR5eL9BSByD7d3y8stNGWO2wTlO6fgCZuwCyySO1LGdc6c0/nOg9K9fbsBYGSf2ncPXSmDQibLC/wQTZRWJGi/9k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ezbzd4Oo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ezbzd4Oo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730984011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4xZlnmGLbCcDQ6CocWnkklikB6SFfbo+Xp/psLT4134=; b=Ezbzd4OoPVgHz7KHVEycpZSpM3RXMQOn/V7DgSzqWd/0BmsQvLR63PqVGTx8BRroTujzUX Dc55sihGtQT7uXLywK9jpc+43oc1miOT80oBcgbTKQiOJ8sMbannTyBLuEh3D7QMCkb50f UHTN29KPuOWVJ5NaM1CcfQJtUd2izy8= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-22-FqOl86oHPt-G_lJNP4psfg-1; Thu, 07 Nov 2024 07:53:30 -0500 X-MC-Unique: FqOl86oHPt-G_lJNP4psfg-1 X-Mimecast-MFC-AGG-ID: FqOl86oHPt-G_lJNP4psfg Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-539fdef0040so630944e87.0 for ; Thu, 07 Nov 2024 04:53:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730984008; x=1731588808; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4xZlnmGLbCcDQ6CocWnkklikB6SFfbo+Xp/psLT4134=; b=K4P/2ZNUdCogZzH9f2JtrQleSt7M9nz1wVivzOf1JjLfrGwQjCWkOA8kfx0wyxGStN jiwiUQuhXaOXu1+wiFhw57ADOmER5PWmiHlz+aiwBC02Yz8XiU3ve3L0t1u1GiF7lMpD 0gqmZ0DO2eUFn3BujRftsoZPSHe9amubjA15H50HUEtsFbzsZvlocVU0pT6sZ3u4bQZS fNHL6Hj/af5hEs2zp3HBgjzXaxBvYARWGPvCQ6iFJWkzDka2BSnp0kXCGYl/WPlAYqrF L/KpyOnhUXpz6EYwFUuLmIAcq/7Y1g1Jv7+ryI1vQPwtxGx3D1quZ/tbRdameAL3r0xE OWGw== X-Forwarded-Encrypted: i=1; AJvYcCXru+EeBjfZxgYBz/TCMo47uObkaBt93sgebKTkhsFTiUHusJNYlXAZWGB7OS7DB/089mR0jqFNc0AfEYU=@vger.kernel.org X-Gm-Message-State: AOJu0YxlnL1dYmJ13TC9pX07GG1DTFYy42sldlu70CVkIEqEwrBjx0M0 39YqMoZHxjRBu9TvTD36o5JU7dC/tM/ativuQGT1SMpqjAhSTN1ysU2KLEOydhxOQcAD8+AOiAy yA8B8phxpExtVKn8yxnS1Le6z81oivUQkltIJkQwy9hkYMJV50ljAanDiIoL6aBwGegO8gYp1 X-Received: by 2002:a05:6512:3d09:b0:536:9f02:17b4 with SMTP id 2adb3069b0e04-53d65e1abb3mr12338930e87.40.1730984008590; Thu, 07 Nov 2024 04:53:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IH9gmuDqgRTc9sMlboo7K/7iSaqGblN8sir2R0TWjctrF4ERVZHkAD+82IUmNT3lixi28Ii5A== X-Received: by 2002:a05:6512:3d09:b0:536:9f02:17b4 with SMTP id 2adb3069b0e04-53d65e1abb3mr12338902e87.40.1730984008117; Thu, 07 Nov 2024 04:53:28 -0800 (PST) Received: from ?IPV6:2003:cb:c708:7900:b88e:c72a:abbd:d3d9? (p200300cbc7087900b88ec72aabbdd3d9.dip0.t-ipconnect.de. [2003:cb:c708:7900:b88e:c72a:abbd:d3d9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432b053069fsm23640725e9.4.2024.11.07.04.53.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2024 04:53:27 -0800 (PST) Message-ID: <00d84e12-4c14-4a6b-a5cd-83d81ac90855@redhat.com> Date: Thu, 7 Nov 2024 13:53:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: fix a possible null pointer dereference in setup_zone_pageset() To: Qiu-ji Chen , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, stable@vger.kernel.org References: <20241107124116.579108-1-chenqiuji666@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241107124116.579108-1-chenqiuji666@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07.11.24 13:41, Qiu-ji Chen wrote: > The function call alloc_percpu() returns a pointer to the memory address, > but it hasn't been checked. Our static analysis tool indicates that null > pointer dereference may exist in pointer zone->per_cpu_pageset. It is > always safe to judge the null pointer before use. > > Signed-off-by: Qiu-ji Chen > Cc: stable@vger.kernel.org > Fixes: 9420f89db2dd ("mm: move most of core MM initialization to mm/mm_init.c") > --- > V2: > Fixed the incorrect code logic. > Thanks David Hildenbrand for helpful suggestion. > --- > mm/page_alloc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 8afab64814dc..7c8a74fd02d6 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5703,8 +5703,14 @@ void __meminit setup_zone_pageset(struct zone *zone) > /* Size may be 0 on !SMP && !NUMA */ > if (sizeof(struct per_cpu_zonestat) > 0) > zone->per_cpu_zonestats = alloc_percpu(struct per_cpu_zonestat); > + if (!zone->per_cpu_zonestats) > + return; > > zone->per_cpu_pageset = alloc_percpu(struct per_cpu_pages); > + if (!zone->per_cpu_pageset) { > + free_percpu(zone->per_cpu_zonestats); > + return; > + } > for_each_possible_cpu(cpu) { > struct per_cpu_pages *pcp; > struct per_cpu_zonestat *pzstats; Unmodified patch, likely not what you wanted to send? -- Cheers, David / dhildenb