|-----Original Message----- |From: linux-kernel-owner@vger.kernel.org |[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Marcin Dalecki |Sent: Monday, July 22, 2002 4:26 PM |To: Christoph Hellwig |Cc: martin@dalecki.de; Linus Torvalds; Kernel Mailing List |Subject: Re: [PATCH] 2.5.27 sysctl | | |Christoph Hellwig wrote: |> On Mon, Jul 22, 2002 at 12:42:07PM +0200, Marcin Dalecki wrote: |> |>>This is making the sysctl code acutally be written in C. |>>It wasn't mostly due to georgeous ommitted size array "forward |>>declarations". As a side effect it makes the table structure |easier to |>>deduce. |> |> |> Please don't remove the trailing commas in the enums. they make |> adding to them much easier and are allowed by gcc (and maybe |C99, I'm |> not sure). | |It's an GNU-ism. If you have any problem with "adding vales", |just invent some dummy end-value. I have a problem with using |-pedantic. Its not, ANSI C allows a trailing comma. Balbir