From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752002AbcBXJVq (ORCPT ); Wed, 24 Feb 2016 04:21:46 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:34361 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbcBXJVn (ORCPT ); Wed, 24 Feb 2016 04:21:43 -0500 X-AuditID: cbfee61b-f793c6d00000236c-f9-56cd76260d02 From: Chao Yu To: Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] f2fs: fix incorrect upper bound when iterating inode mapping tree Date: Wed, 24 Feb 2016 17:20:44 +0800 Message-id: <00e601d16ee4$c359b4d0$4a0d1e70$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AdFu5Jz3deTssjvHRv6O7Bq3hdbA/Q== Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsVy+t9jQV21srNhBkeOmFs8WT+L2eLSIneL y7vmsDkwe2xa1cnmsXvBZyaPz5vkApijuGxSUnMyy1KL9O0SuDI2vrvHXjBVouLTrmXMDYxH hbsYOTkkBEwklj34yQJhi0lcuLeerYuRi0NIYBajxLaJW6CcV4wS1xevYAKpYhNQkVje8R/M FgGyDy26zA5iMwt4SDR2fGcFsYUFIiSenV3EDGKzCKhK/Nz2ACzOK2Ap8e3ma2YIW1Dix+R7 LBC9WhLrdx5ngrDlJTavecsMcZGCxI6zrxkhdulJrL23FapGXGLjkVssExiBzkQYNQvJqFlI Rs1C0rKAkWUVo0RqQXJBcVJ6rlFearlecWJucWleul5yfu4mRnAYP5PewXh4l/shRgEORiUe 3gcbzoQJsSaWFVfmHmKU4GBWEuGdUnw2TIg3JbGyKrUoP76oNCe1+BCjNAeLkjjv4//rwoQE 0hNLUrNTUwtSi2CyTBycUg2MvV3F/0/9d3H6UhgXrjdXMEg7mmGH+4LYD9+sHYSDfpb5tG6s uRD38d8264Ubz1S/+C+ze+nXXztlU0NCLFhcMl5cKQ7X/y/dv4kho4njV6u1OttExfk3OXkV X07qqw1xP+jnEGssZsj4Jzb9RvxRPdXY590K8oHGmfI6/P8u9RzP0Eres1SJpTgj0VCLuag4 EQBw7FNxXwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 1. Inode mapping tree can index page in range of [0, ULONG_MAX], however, in some places, f2fs only search or iterate page in ragne of [0, LONG_MAX], result in miss hitting in page cache. 2. filemap_fdatawait_range accepts range parameters in unit of bytes, so the max range it covers should be [0, LLONG_MAX], if we use [0, LONG_MAX] as range for waiting on writeback, big number of pages will not be covered. This patch corrects above two issues. Signed-off-by: Chao Yu --- fs/f2fs/checkpoint.c | 8 ++++---- fs/f2fs/file.c | 2 +- fs/f2fs/node.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 64bbd06..9d277f8 100644 --- a/fs/f2fs/checkpoint.c +++ b/fs/f2fs/checkpoint.c @@ -282,7 +282,7 @@ long sync_meta_pages(struct f2fs_sb_info *sbi, enum page_type type, long nr_to_write) { struct address_space *mapping = META_MAPPING(sbi); - pgoff_t index = 0, end = LONG_MAX, prev = LONG_MAX; + pgoff_t index = 0, end = ULONG_MAX, prev = ULONG_MAX; struct pagevec pvec; long nwritten = 0; struct writeback_control wbc = { @@ -305,7 +305,7 @@ long sync_meta_pages(struct f2fs_sb_info *sbi, enum page_type type, for (i = 0; i < nr_pages; i++) { struct page *page = pvec.pages[i]; - if (prev == LONG_MAX) + if (prev == ULONG_MAX) prev = page->index - 1; if (nr_to_write != LONG_MAX && page->index != prev + 1) { pagevec_release(&pvec); @@ -1077,8 +1077,8 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) if (unlikely(f2fs_cp_error(sbi))) return -EIO; - filemap_fdatawait_range(NODE_MAPPING(sbi), 0, LONG_MAX); - filemap_fdatawait_range(META_MAPPING(sbi), 0, LONG_MAX); + filemap_fdatawait_range(NODE_MAPPING(sbi), 0, LLONG_MAX); + filemap_fdatawait_range(META_MAPPING(sbi), 0, LLONG_MAX); /* update user_block_counts */ sbi->last_valid_block_count = sbi->total_valid_block_count; diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 935a60a..f326764 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -301,7 +301,7 @@ static pgoff_t __get_first_dirty_index(struct address_space *mapping, pagevec_init(&pvec, 0); nr_pages = pagevec_lookup_tag(&pvec, mapping, &pgofs, PAGECACHE_TAG_DIRTY, 1); - pgofs = nr_pages ? pvec.pages[0]->index : LONG_MAX; + pgofs = nr_pages ? pvec.pages[0]->index : ULONG_MAX; pagevec_release(&pvec); return pgofs; } diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 68506f4..7b613dd 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1238,7 +1238,7 @@ int sync_node_pages(struct f2fs_sb_info *sbi, nid_t ino, next_step: index = 0; - end = LONG_MAX; + end = ULONG_MAX; while (index <= end) { int i, nr_pages; @@ -1354,7 +1354,7 @@ continue_unlock: int wait_on_node_pages_writeback(struct f2fs_sb_info *sbi, nid_t ino) { - pgoff_t index = 0, end = LONG_MAX; + pgoff_t index = 0, end = ULONG_MAX; struct pagevec pvec; int ret2 = 0, ret = 0; -- 2.7.0