From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42B5C433E2 for ; Tue, 15 Sep 2020 02:30:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70C88206E6 for ; Tue, 15 Sep 2020 02:30:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726068AbgIOCaI (ORCPT ); Mon, 14 Sep 2020 22:30:08 -0400 Received: from smtprelay0039.hostedemail.com ([216.40.44.39]:59580 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726019AbgIOCaG (ORCPT ); Mon, 14 Sep 2020 22:30:06 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id A2F8618029122; Tue, 15 Sep 2020 02:30:04 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: coil86_0f0b38c2710d X-Filterd-Recvd-Size: 1720 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA; Tue, 15 Sep 2020 02:30:03 +0000 (UTC) Message-ID: <00e6faaceed28ceb81777a63caffc512885a6efb.camel@perches.com> Subject: Re: [PATCH 3/3] staging: rtl8723bs: os_dep: fixed spacing around operators issue From: Joe Perches To: Ross Schmidt , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 14 Sep 2020 19:30:02 -0700 In-Reply-To: <20200915001731.28986-3-ross.schm.dev@gmail.com> References: <20200915001731.28986-1-ross.schm.dev@gmail.com> <20200915001731.28986-3-ross.schm.dev@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-09-14 at 19:17 -0500, Ross Schmidt wrote: > Fixed a coding style issue by adding spaces around operators in > sdio_ops_linux.c to fix checkpatch checks. Hello Ross. If you want to do more than fix whitespace, please look at the #define for DBG_871X. All the uses with a KERN_ are broken and should be modified as _dbgdump is just printk and DRIVER_PREFIX is "RTL8723BS: " so the KERN_ after the DRIVER_PREFIX. That's just broken. #define DBG_871X(...) do {\ _dbgdump(DRIVER_PREFIX __VA_ARGS__);\ } while (0) Realistically, the DBG_871X macro family should just use pr_debug and all the KERN_ uses should be removed. The define and uses of RT_TRACE should also just be converted to use pr_debug or some other function to perhaps reduce overall object size