From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C15C54EBC for ; Wed, 11 Jan 2023 16:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234247AbjAKQCI (ORCPT ); Wed, 11 Jan 2023 11:02:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230428AbjAKQCC (ORCPT ); Wed, 11 Jan 2023 11:02:02 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DD7BDFAC for ; Wed, 11 Jan 2023 08:02:01 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id p1-20020a05600c1d8100b003d8c9b191e0so13026804wms.4 for ; Wed, 11 Jan 2023 08:02:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DjqMdLByHpLoEIU1jYOWhc1we/OiwFPjgi5FyeOCdB8=; b=ZrLQdUCY74MoBu0zoirjD4mlppIWqjcPOSUeG1WAvpBSUgu0qVyNoXWIKUobMtkL5u E9dD6ofp7GbYoovsl5KSTm0jdpDJDvrdlszOgoG6EJreslvykd8lx8ULyf+mi1XOAf1C io7qfSm2S1MJHDkqQVq9e1/knS3QaeD+rZgwwzR9ZIl3zutXDtbhemiaafvjb1yrPnwo QI9O37nCQojkKgLOq8Ldmpgd7R/8TSK4tK++NZmb4qnz6Yd5hnr6JE76vXCpB6QpSb86 8OQ9nbWqrNGjDm5pdq2bi78XhB7f1FJ9/gqFRbx0AhN7Y3SMr3pVJgOmzzfTDN2rxxOe /zHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DjqMdLByHpLoEIU1jYOWhc1we/OiwFPjgi5FyeOCdB8=; b=HJONvueeL51VcTUVXHQux7/g2TvCAIuV5SiIkCysFHCm8EFx44c4SeE9S8RWJbPQrc g58oem5xzy064FcOcEz2kEZ2KsqJKsdYy6L/8ssG4joDiRobNRdzipj9+Us9b+7CyC/a bXh6Nak+Kuy3A4FYkUTbU4EG0BWnzWN3aXKfknWFqE/5MTJzcu7s1z0wbFp8p53RT1Zl 5Hgz+Y/bUsMilDdTMV39fLvDGQnRvEVK1qkGhzMiVR3uoNeLr9BEM3/xzYjPH5MUx8Yn fFD/W4Q/ussdkLeeBh/8tBigPgD/RPq+hcxFRvEDftaGMDOH7EFg581L+WhUE3EKWnWQ KTyQ== X-Gm-Message-State: AFqh2kpH6jgr6IWg6dSAd4ZFCCU7EukrRy6koSpTQzyZp48VWrsufmYv ABQLXg4ElxMSsX70HJk1JTilcQ== X-Google-Smtp-Source: AMrXdXuk3q7XJQY4rIfLnB0mHA1lZZLrIadu5j8SGH4zSrdf1Cl/mdJp34MgXIym+vcCtyM7TBhD1Q== X-Received: by 2002:a05:600c:34d0:b0:3d6:b691:b80d with SMTP id d16-20020a05600c34d000b003d6b691b80dmr52090685wmq.21.1673452920157; Wed, 11 Jan 2023 08:02:00 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id p3-20020a05600c358300b003d1f2c3e571sm26075424wmq.33.2023.01.11.08.01.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 08:01:59 -0800 (PST) Message-ID: <00e70137-3cc3-877e-5435-ac15f750f466@linaro.org> Date: Wed, 11 Jan 2023 16:01:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH V8 2/2] firmware: qcom: scm: Add wait-queue handling logic Content-Language: en-US To: Sibi Sankar , andersson@kernel.org Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, konrad.dybcio@somainline.org, robimarko@gmail.com, quic_gurus@quicinc.com References: <20230111101718.9225-1-quic_sibis@quicinc.com> <20230111101718.9225-3-quic_sibis@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <20230111101718.9225-3-quic_sibis@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/01/2023 10:17, Sibi Sankar wrote: > +static int qcom_scm_waitq_wakeup(struct qcom_scm *scm, unsigned int wq_ctx, bool wake_all) > +{ > + int ret; > + > + ret = qcom_scm_assert_valid_wq_ctx(wq_ctx); > + if (ret) > + return ret; > + > + if (wake_all) > + complete_all(&__scm->waitq_comp); As you explained in v7 that there will be only one caller at any point in time and that will be synchronous, so complete_all here is a dead code, isn't it? Adding complete_all here is missleading and will require reinit completion in case you want to reuse the same completion. AFAIU, you should remove support to wake_all in this patchset and add it when we really can do multiple scm calls simultaneously. --srini --srini > + else > + complete(&__scm->waitq_comp); > +