mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Timo Alho <talho@nvidia.com>
To: <thierry.reding@gmail.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Timo Alho <talho@nvidia.com>
Subject: [PATCH 3/4] reset: tegra: check BPMP response return code
Date: Thu, 7 Sep 2017 12:31:03 +0300	[thread overview]
Message-ID: <00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com> (raw)
In-Reply-To: <cover.1504776489.git.talho@nvidia.com>

Add checks for return code in BPMP response message.

Signed-off-by: Timo Alho <talho@nvidia.com>
---
 drivers/reset/tegra/reset-bpmp.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c
index 5daf2ee..fac2db6 100644
--- a/drivers/reset/tegra/reset-bpmp.c
+++ b/drivers/reset/tegra/reset-bpmp.c
@@ -23,6 +23,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
 	struct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);
 	struct mrq_reset_request request;
 	struct tegra_bpmp_message msg;
+	int err;
 
 	memset(&request, 0, sizeof(request));
 	request.cmd = command;
@@ -33,7 +34,13 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,
 	msg.tx.data = &request;
 	msg.tx.size = sizeof(request);
 
-	return tegra_bpmp_transfer(bpmp, &msg);
+	err = tegra_bpmp_transfer(bpmp, &msg);
+	if (err < 0)
+		return err;
+	else if (msg.rx.ret < 0)
+		return -EINVAL;
+
+	return 0;
 }
 
 static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,
-- 
2.7.4

  parent reply	other threads:[~2017-09-07  9:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-07  9:31 [PATCH 0/4] firmware: tegra: add checks for BPMP error " Timo Alho
2017-09-07  9:31 ` [PATCH 1/4] firmware: tegra: propagate error code to caller Timo Alho
2017-09-21 11:19   ` Jon Hunter
2017-10-17 10:41   ` Thierry Reding
2017-09-07  9:31 ` [PATCH 2/4] clk: tegra: check BPMP response return code Timo Alho
2017-09-21 11:21   ` Jon Hunter
2017-09-29 13:46     ` Timo Alho
2017-09-29 14:53       ` Jon Hunter
2017-10-02  8:43         ` Timo Alho
2017-10-02 20:23           ` Jon Hunter
2017-10-17 10:37   ` Thierry Reding
2017-10-21 14:10     ` Stephen Boyd
2017-09-07  9:31 ` Timo Alho [this message]
2017-10-02 20:24   ` [PATCH 3/4] reset: " Jon Hunter
2017-10-17 10:40   ` Thierry Reding
2017-10-17 10:52     ` Philipp Zabel
2017-10-17 11:49       ` Thierry Reding
2017-09-07  9:31 ` [PATCH 4/4] soc/tegra: bpmp: " Timo Alho
2017-10-02 20:26   ` Jon Hunter
2017-10-17 10:41   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com \
    --to=talho@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®