From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752100AbdBTDau (ORCPT <rfc822;w@1wt.eu>);
        Sun, 19 Feb 2017 22:30:50 -0500
Received: from out0-140.mail.aliyun.com ([140.205.0.140]:51009 "EHLO
        out0-140.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752020AbdBTDat (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 19 Feb 2017 22:30:49 -0500
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03268;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=6;SC=85;SR=0;TI=SMTPD_---.7fGQqXM_1487561426;
Reply-To: "Hillf Danton" <hillf.zj@alibaba-inc.com>
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Aneesh Kumar K.V'" <aneesh.kumar@linux.vnet.ibm.com>,
        <akpm@linux-foundation.org>, "'Rik van Riel'" <riel@surriel.com>,
        "'Mel Gorman'" <mgorman@techsingularity.net>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
References: <1487498395-9544-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <1487498395-9544-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.
Date: Mon, 20 Feb 2017 11:30:26 +0800
Message-ID: <00ec01d28b29$adb7ce70$09276b50$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQGHTTL3Xacj+HROWbcGB3Blq5N+aqIHt5cg
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On February 19, 2017 6:00 PM Aneesh Kumar K.V wrote: 
> 
> We are using wrong flag value in task_numa_falt function. This can result in
> us doing wrong numa fault statistics update, because we update num_pages_migrate
> and numa_fault_locality etc based on the flag argument passed.
> 
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

Fix: bae473a423 ("mm: introduce fault_env")
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>

> ---
>  mm/huge_memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 5f3ad65c85de..8f1d93257fb9 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1333,7 +1333,7 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)
> 
>  	if (page_nid != -1)
>  		task_numa_fault(last_cpupid, page_nid, HPAGE_PMD_NR,
> -				vmf->flags);
> +				flags);
> 
>  	return 0;
>  }
> --
> 2.7.4