From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC4BCA9EB7 for ; Tue, 22 Oct 2019 07:48:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60DC920B7C for ; Tue, 22 Oct 2019 07:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388020AbfJVHsv (ORCPT ); Tue, 22 Oct 2019 03:48:51 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:44812 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729458AbfJVHsu (ORCPT ); Tue, 22 Oct 2019 03:48:50 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 1CD9D28C250 Subject: Re: [PATCH 1/2] rtc: cros-ec: remove superfluous error message To: Alexandre Belloni , linux-rtc@vger.kernel.org Cc: Benson Leung , Guenter Roeck , linux-kernel@vger.kernel.org References: <20191016201414.30934-1-alexandre.belloni@bootlin.com> From: Enric Balletbo i Serra Message-ID: <00ed2977-3627-16ca-6a01-db263534a071@collabora.com> Date: Tue, 22 Oct 2019 09:48:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191016201414.30934-1-alexandre.belloni@bootlin.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On 16/10/19 22:14, Alexandre Belloni wrote: > The RTC core now has error messages in case of registration failure, there > is no need to have other messages in the drivers. > > Signed-off-by: Alexandre Belloni That makes totally sense for me. Reviewed-by: Enric Balletbo i Serra > --- > drivers/rtc/rtc-cros-ec.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c > index 6909e01936d9..da209d00731e 100644 > --- a/drivers/rtc/rtc-cros-ec.c > +++ b/drivers/rtc/rtc-cros-ec.c > @@ -351,11 +351,8 @@ static int cros_ec_rtc_probe(struct platform_device *pdev) > cros_ec_rtc->rtc = devm_rtc_device_register(&pdev->dev, DRV_NAME, > &cros_ec_rtc_ops, > THIS_MODULE); > - if (IS_ERR(cros_ec_rtc->rtc)) { > - ret = PTR_ERR(cros_ec_rtc->rtc); > - dev_err(&pdev->dev, "failed to register rtc device\n"); > - return ret; > - } > + if (IS_ERR(cros_ec_rtc->rtc)) > + return PTR_ERR(cros_ec_rtc->rtc); > > /* Get RTC events from the EC. */ > cros_ec_rtc->notifier.notifier_call = cros_ec_rtc_event; >