From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1AF63859D3 for ; Mon, 25 May 2026 13:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779715966; cv=none; b=rFGB3pbSxuCDe4kFGcPGjKO1t/Lb2J7720Yx+nHGdM5yB1tapP6ds+Uc299CbI0BAAAmmJOVbUeicnPq2NxyP20BZNpB0pezrwTGAlNzKluUF1py50gt/RzVYa3NquH01dQqUdG6Ap+zz7JnfNCFdlscAHcdwQC8xU0zedjzy8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779715966; c=relaxed/simple; bh=u1ow/i9niuENMjtqNOhto9R54yrc9dgiAXBNWCwVV9Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CVSXDX7pi7cy3igQ+jEgdxrn2KTsnyeLEKnD1lJr+wA1As1ZtsBrZjjOVs/DKXtiWPsOwFVFt/zv24kaIy1+Y4FboJ+hgkYCR6e98WuztbqJ7AvbDRaNHS+/UvirmA96GpKjxbY34/mcYKv1H4SIyl7Rq2FrOXlTpjFLUQLixgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dYeSHzfp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UOC+F8FU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dYeSHzfp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UOC+F8FU" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64P9EJdL079191 for ; Mon, 25 May 2026 13:32:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iJf8SHZ8adk67Gfl+mwlKWiNU1Nx1Ly7j7+/7kZEWZo=; b=dYeSHzfpjdetWSDB BE3WGbNmn1PknpNnJljB5RP+KkYU7f8ngYBw+TX+rDpWUZu8WNkNmEaZzB4hYrCk iFai4Eb+FTPTw8DLd4tbFSWgGRrMOd4pxw96+kKKJWG8AQeT+NnjwdMxTFYxrt5E ky+SnooPN7jQvGvETIgC65xD79EMrJn08kRt8tugsFmCLdRyN0Uuqv59OFODwK2C MCcd+zVtf4JkcsLd185PHAGaLn76Z06qId6QFdwQAVakDixzbsDWMEWzqy3+fneI I4umIjNvlPuDX9XKZtR9OmRL/1X60HUzPxC95cQTfD69rIzjlVKdIcpN9vARANLo LekPrw== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eckma8u05-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 25 May 2026 13:32:44 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7e600612e36so984954a34.1 for ; Mon, 25 May 2026 06:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779715963; x=1780320763; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iJf8SHZ8adk67Gfl+mwlKWiNU1Nx1Ly7j7+/7kZEWZo=; b=UOC+F8FUFAXRwptXfogep6xtUkPlIXo7P8ERz0kps/qGRikGNLOvQGFS0XD2cbfaeO lO56FyQTRDDTw/nE/HiK0xbE7NgnqcdnCHcNR7k+aBfOfOnr3zH8fhKEbU6llIdCEwI8 becN6Fa55Lm3lqaAmQx4gywPyHfj8kZ9dhrpwuQIezZspNWKSVZ6gq36nuS8oVN3bqdA AG6R6KlqDWQheNtpxYiSOZ5HF3E1MC1yXHcuC88nDy1T4ntL+17I7ssGaL2miHgDZ+zT 38Qb+06auPKBg9NzJTrplS3Tgo4tEyJvr0fhvYbma/md1BSS/v1Z5/lbfNMEj6sPmsRL uPMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779715963; x=1780320763; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iJf8SHZ8adk67Gfl+mwlKWiNU1Nx1Ly7j7+/7kZEWZo=; b=rMToizKcl8XIge8gop6dG1J+CoBXYTl/PxWtfLZI7i4b8hm8VuvoM3vpCC6mbYxMtz 7ut15AxqKdqNPTN5bUiWHSvHGMmmj7Zi54YFxREyGIpwXv2wToa4eNe4fjaeFvho+yp4 s5RWyK6/MgWb8fVPHDkAWhiUfF+ncqaMz0N3W0QZDA0tPqVe6OJoVcVpsCGHiagWmmqJ 0lDlbBMW5JHGrE000zjAHY6k4HGZ9+JrNsp6yC819dKxu2WVQv1VJx4BYVTpetIqCRP1 CW+XbiNLGRrP3/vWJiLYVEk8ZI1vY9MmP+sqAKi6HDShwunKfjqimpFSosYIISZbT1pw tgzw== X-Forwarded-Encrypted: i=1; AFNElJ+Cn82fKQzruACRPnbpvkX2kkmgXpYjIrztA31F3fTh+x5TQyoSjzOu23fIvuaY8rnLgUv0UHER1Mx13Qo=@vger.kernel.org X-Gm-Message-State: AOJu0YzZLrOrB++sL/kJgDxW1ZP1VIf2J/P7h/btDhchHvFQ9U3LXnt6 5JNsUxOePsjmQa2YnoftdsyMu7q7wj5Wda2+qFeCwtbvAly8D/tBMqfJ5zqPyqMqTllObGosKMC G0aVe/hNHZtezE7PTmg2L/5KuI8F6UfCbvEqPMpL7YW6xHVhtFiUbDr8i+xKf8AbVBtw= X-Gm-Gg: Acq92OHOMLcsH8bJ1Gu8p6Fgf2KaPnLMWDaFd0N5on0Bsx6gc/sC3amjlMnlR0O/T3p L35+Avrid4VNZbtAOfysyrf2JWrGxomxN8b4CYsKZb/hRY9c0ZcN6pLfOPKwBfwBNK7vAdJisPK miEa6upUQHOL8n8KJklmXx3Fje06LcJjfUA4o2ogaypYOmN51WjnSsj2lQb10dchwAAD5lLWW/w MjgaI3nDfJnaJFZHK1QDkXOeBxtdewQDGt28UN5LOrvhUjckIrVzdHqjGKQNYJP+CEgZGjP5UvH Ka84bgPLtcuCnakv1ZQAlyFKBce46kZ51zTZzZoOINBRovu0Vjr+JcQaFhT7yy4ZP8LsUJjAIOw 9KrwwZ29VpINFN49MMmMfH/NkUu9D3K4ROC2OPvrjxw6arcZDAYuMkcMR X-Received: by 2002:a4a:ec4c:0:b0:695:94b4:d4bf with SMTP id 006d021491bc7-69d7e83053emr4656097eaf.0.1779715963297; Mon, 25 May 2026 06:32:43 -0700 (PDT) X-Received: by 2002:a4a:ec4c:0:b0:695:94b4:d4bf with SMTP id 006d021491bc7-69d7e83053emr4656085eaf.0.1779715962851; Mon, 25 May 2026 06:32:42 -0700 (PDT) Received: from [192.168.119.254] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc5eced0asm401848066b.39.2026.05.25.06.32.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 06:32:42 -0700 (PDT) Message-ID: <00ee4b34-7f71-4448-806b-65bd62ebe574@oss.qualcomm.com> Date: Mon, 25 May 2026 15:32:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/10] drm/msm/dp: Read DPCD and sink count in bridge detect() To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang , Val Packett References: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> <20260524-hpd-refactor-v6-3-cf3ab488dd7b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260524-hpd-refactor-v6-3-cf3ab488dd7b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=cL3QdFeN c=1 sm=1 tr=0 ts=6a144f7c cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=e2WOG6c8x0SVvsxun3UA:9 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 X-Proofpoint-ORIG-GUID: 8B8DfUT1fze81Hzml1vyCdyUBJrMxk4W X-Proofpoint-GUID: 8B8DfUT1fze81Hzml1vyCdyUBJrMxk4W X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI1MDEzOCBTYWx0ZWRfX360gHfNAXCof plJcFpzGEefkcG0AP6Oe7YE22RzGYDWkfBObZq6ECtduL9+S4cR/WTCsX85jjtPSAVyenC/iF8H uFRGGYh/b9zm7ay+QAHBViPrxi8XUsjXp9yCvj4lfw4MpkTfpDCw5cT32Wmd1IdDBzJBfMl5aDf FXj7CHrKPAws6N2UsDhXgIXnTElRlO75M9wNgouGmbhXWNwUJfvv4Ax6+2SJeOinZEysp61B0Aj zDSTXMPHEPGQa5kTA8/pQpeTpq4VFI1ccfyWj2jMhJrwWQwIPC8dfsSid4/NvE/RccQHvb3mgoS DYbbLdq27bQzdDv0bkptre9rFl4h5e14B6fuZNZ9iI3Ku2TUzRO/WOiPv8uXAIPTMMGu/Fkw7i8 kQgX7RTzKXDo2xvCME0/f/2hnqPrEuNeqLch/EGhl2oNS3uqf1EBjPaVi3B7nU1o68qyXqdqr+k EDHGSZldZbrUbxvUt3g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-25_04,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605250138 On 5/24/26 12:33 PM, Dmitry Baryshkov wrote: > From: Jessica Zhang > > Instead of relying on the link_ready flag to specify if DP is connected, > read the DPCD bits and get the sink count to accurately detect if DP is > connected. > > Signed-off-by: Jessica Zhang > Tested-by: Val Packett # x1e80100-dell-latitude-7455 > Tested-by: Yongxing Mou # Hamoa IOT EVK, QCS8300 Ride > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 63 +++++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/msm/dp/dp_drm.c | 20 ------------ > drivers/gpu/drm/msm/dp/dp_drm.h | 2 ++ > 3 files changed, 65 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 1dd168acbbc3..97c4752005c0 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1152,6 +1152,69 @@ static int msm_dp_hpd_event_thread_start(struct msm_dp_display_private *msm_dp_p > return 0; > } > > +/** > + * msm_dp_bridge_detect - callback to determine if connector is connected > + * > + * @bridge: Pointer to drm bridge structure > + * @connector: Pointer to drm connector structure > + * > + * Returns: where there is a display connected to the DPTX (returning whether? Otherwise, if keeping msm_dp_aux_enable_xfers(true) is intentional in bailout cases: Reviewed-by: Konrad Dybcio Konrad