From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752441AbbDQHLn (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Apr 2015 03:11:43 -0400
Received: from mail113-249.mail.alibaba.com ([205.204.113.249]:53843 "EHLO
	us-alimail-mta1.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751775AbbDQHLg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Apr 2015 03:11:36 -0400
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=r46d02002;MF=hillf.zj@alibaba-inc.com;PH=DS;RN=5;RT=5;SR=0;
Reply-To: "Hillf Danton" <hillf.zj@alibaba-inc.com>
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Dave Hansen'" <dave.hansen@linux.intel.com>,
        "'Mike Kravetz'" <mike.kravetz@oracle.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        "Michal Hocko" <mhocko@suse.cz>
References: <00e601d078da$9e762190$db6264b0$@alibaba-inc.com>
In-Reply-To: <00e601d078da$9e762190$db6264b0$@alibaba-inc.com>
Subject: Re: [RFC PATCH 4/4] mm: madvise allow remove operation for hugetlbfs
Date: Fri, 17 Apr 2015 15:10:29 +0800
Message-ID: <00ef01d078dd$96bfc480$c43f4d80$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQFw0oquaElP0jkmIBkr+kg3iwcnsZ4QEC3Q
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> 
> Now that we have hole punching support for hugetlbfs, we can
> also support the MADV_REMOVE interface to it.
> 
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
> ---
>  mm/madvise.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/madvise.c b/mm/madvise.c
> index d551475..c4a1027 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -299,7 +299,7 @@ static long madvise_remove(struct vm_area_struct *vma,
> 
>  	*prev = NULL;	/* tell sys_madvise we drop mmap_sem */
> 
> -	if (vma->vm_flags & (VM_LOCKED | VM_HUGETLB))
> +	if (vma->vm_flags & VM_LOCKED)
>  		return -EINVAL;
> 
>  	f = vma->vm_file;
> --
> 2.1.0

After the above change offset is computed,

	offset = (loff_t)(start - vma->vm_start)
		+ ((loff_t)vma->vm_pgoff << PAGE_SHIFT);

and I wonder if it is correct for huge page mapping.

Hillf