From: Daniel Baluta <daniel.baluta@oss.nxp.com>
To: Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm64: dts: freescale: imx95-toradex-smarc: Support Cortex M7
Date: Wed, 4 Mar 2026 18:11:01 +0200 [thread overview]
Message-ID: <00f3e52a-05d1-4b47-8799-2c5250d27c1e@oss.nxp.com> (raw)
In-Reply-To: <20260303210131.2966214-14-Frank.Li@nxp.com>
On 3/3/26 23:01, Frank Li wrote:
> From: Frank Li (AI-BOT) <frank.li@nxp.com>
>
> AI bot review and may be useless.
>
> ---
>
>> + cm7: remoteproc-cm7 {
>> + compatible = "fsl,imx95-cm7";
>> + mbox-names = "tx", "rx", "rxdb";
>> + mboxes = <&mu7 0 1
>> + &mu7 1 1
>> + &mu7 3 1>;
>> + memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>,
>> + <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>, <&m7_reserved>;
>> + };
> Line 51 exceeds 80 columns; consider breaking memory-region into
> multiple lines for readability.
Frank please relax your bot!
As of commit bdc48fa11e46f867ea ("checkpatch/coding-style: deprecate 80-column warning")
there is no such requirement for wrapping at 80 chars anymore.
<snip>
>> +&mu7 {
>> + status = "okay";
>> +};
> Ensure mu7 node is defined elsewhere in the base device tree; this
> patch only enables it without defining its properties.
>
Well it should fail compilation if mu7 was not defined? Sometimes this comments can be confusing so please
review them carefully before replying.
prev parent reply other threads:[~2026-03-04 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 12:13 Emanuele Ghidoli
2026-03-03 15:38 ` Frank Li
2026-03-03 15:55 ` Emanuele Ghidoli
2026-03-05 1:14 ` Peng Fan
2026-03-03 21:01 ` Frank Li
2026-03-04 15:52 ` Krzysztof Kozlowski
2026-03-04 16:11 ` Daniel Baluta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00f3e52a-05d1-4b47-8799-2c5250d27c1e@oss.nxp.com \
--to=daniel.baluta@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emanuele.ghidoli@toradex.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®