From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8755240DFA6 for ; Thu, 9 Apr 2026 13:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775739868; cv=none; b=EgcNRitW1UNiJaXzJ6tjk79I0p1dH9UZMRA46JTrHr5JOSemGzvIoYwwC10gW15cGK3wOAX/sFxHjDh2ldPit1TAJWYDT2cDaoZ3acavslbyP5m+Ge2eGoe4FYSe0PFvWj6N4CRYz2Iw0l07Iu473Sf/XHCW+t0J4X8NRvCjRFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775739868; c=relaxed/simple; bh=edxyJPIpDcrkfXUhyUoWo4ZmUknvNS6KHcMk8cn0t/I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EtnHyLMGHdtX2uBA3496OOOz0YVHBRfd1yGSzZErlOrjS5uGUdX12sX/bYPcKJgp59tXbEBGk2mumLZbkyoV+WXPf3o/isidoH0ZAPBhNd+jfgFIPWlbtLw9qKxrMiDin4qLfnsLcfPC5fU/tugksl6D9D7ftXpnoEN+X4Rxtp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=WEWHru9M; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="WEWHru9M" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 450752F9D; Thu, 9 Apr 2026 06:04:21 -0700 (PDT) Received: from [10.164.148.43] (unknown [10.164.148.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 66B673F641; Thu, 9 Apr 2026 06:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1775739867; bh=edxyJPIpDcrkfXUhyUoWo4ZmUknvNS6KHcMk8cn0t/I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WEWHru9Mm8PVscGfg0HS2jjbC3uPW/84RjXSA79iGQDftHDSidtj4+Za4wgmICpZ8 YgeyOYc20NhpLSo8TPZdbrMHyvxKRzDm5PQ80YA6AsBTkD9sJPqHOFR3NQNDMr1THh D5bgeFoJdi/FmHS8Zyz8SYKked/kVDY6P4nMrIt4= Message-ID: <00f8f77c-c9b2-4900-ba9b-52d6fe2332bd@arm.com> Date: Thu, 9 Apr 2026 18:34:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/khugepaged: use ALIGN helpers for PMD alignment To: Ye Liu , Andrew Morton , David Hildenbrand , Lorenzo Stoakes Cc: Ye Liu , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260409014323.2385982-1-ye.liu@linux.dev> Content-Language: en-US From: Dev Jain In-Reply-To: <20260409014323.2385982-1-ye.liu@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/04/26 7:13 am, Ye Liu wrote: > From: Ye Liu > > PMD alignment in khugepaged is currently implemented using a mix of > rounding helpers and open-coded bitmask operations. > > Use ALIGN() and ALIGN_DOWN() consistently for PMD-sized address range > alignment, matching the preferred style for address and size handling. > > No functional change intended. > > Signed-off-by: Ye Liu > > Changes in v2: > - Switch to ALIGN()/ALIGN_DOWN() per David's suggestion. > - Also convert collapse_scan_mm_slot() to keep PMD alignment helpers > consistent within khugepaged. > - Update the changelog accordingly. > - Link to v1:https://lore.kernel.org/all/20260408093534.2373007-1-ye.liu@linux.dev/ > --- Reviewed-by: Dev Jain