From: "yukuai (C)" <yukuai3@huawei.com>
To: Jan Kara <jack@suse.cz>
Cc: <tj@kernel.org>, <axboe@kernel.dk>, <paolo.valente@linaro.org>,
<cgroups@vger.kernel.org>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <yi.zhang@huawei.com>
Subject: Re: [PATCH -next v4 1/3] block, bfq: record how many queues are busy in bfq_group
Date: Thu, 28 Apr 2022 19:27:28 +0800 [thread overview]
Message-ID: <00fafd9e-5433-70d8-6493-46a2cc78ec97@huawei.com> (raw)
In-Reply-To: <20220428111800.aqfzwwii5dabx3ko@quack3.lan>
在 2022/04/28 19:18, Jan Kara 写道:
> On Thu 28-04-22 19:19:05, Yu Kuai wrote:
>> Prepare to refactor the counting of 'num_groups_with_pending_reqs'.
>>
>> Add a counter 'busy_queues' in bfq_group, and update it in
>> bfq_add/del_bfqq_busy().
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>
> Just two nits below:
>
>> --- a/block/bfq-wf2q.c
>> +++ b/block/bfq-wf2q.c
>> @@ -218,6 +218,16 @@ static bool bfq_no_longer_next_in_service(struct bfq_entity *entity)
>> return false;
>> }
>>
>> +static void bfq_add_busy_queues(struct bfq_queue *bfqq)
>> +{
>> + bfqq_group(bfqq)->busy_queues++;
>> +}
>> +
>> +static void bfq_dec_busy_queues(struct bfq_queue *bfqq)
>> +{
>> + bfqq_group(bfqq)->busy_queues--;
>> +}
>> +
>
> An opposite from "decrement" is "increment", not "add". So
> bfq_add_busy_queues() should be bfq_inc_busy_queues().
You are right
>
>> @@ -230,6 +240,14 @@ static bool bfq_no_longer_next_in_service(struct bfq_entity *entity)
>> return true;
>> }
>>
>> +static void bfq_add_busy_queues(struct bfq_queue *bfqq)
>> +{
>> +}
>> +
>> +static void bfq_add_busy_queues(struct bfq_queue *bfqq)
>> +{
>> +}
>> +
>
> You have two times the same function here and you miss the other one...
oops, I forgot to compile without CONFIG_BFQ_GROUP_IOSCHED...
Thanks a lot to spolt this.
Kuai
>
> Honza
>
next prev parent reply other threads:[~2022-04-28 11:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 11:19 [PATCH -next v4 0/3] support concurrent sync io for bfq on a specail occasion Yu Kuai
2022-04-28 11:19 ` [PATCH -next v4 1/3] block, bfq: record how many queues are busy in bfq_group Yu Kuai
2022-04-28 11:18 ` Jan Kara
2022-04-28 11:27 ` yukuai (C) [this message]
2022-04-28 11:19 ` [PATCH -next v4 2/3] block, bfq: refactor the counting of 'num_groups_with_pending_reqs' Yu Kuai
2022-04-28 11:23 ` Jan Kara
2022-04-28 11:19 ` [PATCH -next v4 3/3] block, bfq: do not idle if only one group is activated Yu Kuai
2022-04-28 11:24 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00fafd9e-5433-70d8-6493-46a2cc78ec97@huawei.com \
--to=yukuai3@huawei.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®