From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AAFB2BEC5E for ; Wed, 15 Jul 2026 17:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784137896; cv=none; b=FNPvP4a4Vt5s4dPU6P3rJiLtDfjue5DuwWm05GXX0BbzP/rOUQzjfG0phLcv8CHKA0L3HpKEooWagX2Jibgl3YSlOgOOrYMXlO8ClGvSS/7g8FhC3TPmAgeeLFkHd2YJncPeYdl8YfUtwplixAiz/hYXnuGwzCgtLKL4ZhEEkW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784137896; c=relaxed/simple; bh=3WB6DNf1xk14Xxosd3dsF2oSQXuZN3ym9c54bVMqS/Y=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=X9T2MtZvA3QUL9G2iQggnXkxG3xxcRuPRJG6CR7zm7Q8S1mI7OuW9R1pTmBFDCaVuAWrseO/N6ufeGu9kJL+nTtpIfY1GyhiDPowJRya9dxax4q6SnzIGKdj58+PcSqmF6ZCUGfqZEBL5+8dZHcxqKPnwRJRYZQ2T7R1SHBP/b8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com; spf=pass smtp.mailfrom=dubeyko.com; dkim=pass (2048-bit key) header.d=dubeyko-com.20251104.gappssmtp.com header.i=@dubeyko-com.20251104.gappssmtp.com header.b=cHLG6lWm; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dubeyko-com.20251104.gappssmtp.com header.i=@dubeyko-com.20251104.gappssmtp.com header.b="cHLG6lWm" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-80dc4a68e4aso47258877b3.0 for ; Wed, 15 Jul 2026 10:51:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dubeyko-com.20251104.gappssmtp.com; s=20251104; t=1784137894; x=1784742694; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=gV9UHv1FVMFJV/mrKWANR8uUYmepHxhDQGReXLFTg6M=; b=cHLG6lWm3P6hsjYdk5elw0PKxWVBxl1Xh+lhU4tAORP8NEV8Upda4Hkn2YNuzabXoV KeiGnjT1hfBSHAx8kNs3ercHCzoml6YYEE8Rgb8LPTIRmHC30PU+u1yNcbftG4oMSLG4 4CxEAkGYZ0b1vxlLE8PcOWBKM7nE+TqEXQLWapE0dnfVfZ75/BHx31s3fKDJqUzWoBt3 Fnq0gJ3XP8qiWN/+Sr+MsQsDbMEyNUZuYQb88TB6Hj5fJbw71c4WGxPC6zYQkzJhtqVw eEkTJ9XjtqiYl8biZfK16AQC4UxtZtRIxBYVnVoOgiTPwKpgtCtqWS15kHNUIKhzsHaj ni+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784137894; x=1784742694; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=gV9UHv1FVMFJV/mrKWANR8uUYmepHxhDQGReXLFTg6M=; b=kxczWoR6y9lzx7h8eS94/wmlKSGVH/AjJp3QIEelXh//Jay2fvRIl5f1gNnnwaKifN 2wUOsSKRiJZzA9225sHYVjPx4fIrOlAhBKuRbyaTFpsGNg7KInNrAjHbq1S+q+etrVYM bXUjdzFb1SdLVwmthF1P2FEuMmvW2ycEDphpG5dTqRGLvEuXVajXlThdxkeNmkl0slzs Yo2d2XRLo147yf9VAp2W9rItwOYngZ6xmjXMPOjsIDBvByut8PI0W5aWzm2kkP86SbAE 2AemztGqAb0jn1MaQGHEQ2rV+Hv0oJ6m9F+KDsyvMO8/vc2Pe+HvLfrIlaalNTYwh3cc jetw== X-Forwarded-Encrypted: i=1; AHgh+RocNJZMAgtKytgja4X5XZqwxk+TSwOL2/8TtWqP9ngcztTjt5/DdHjrbna1r1VleKYj4Za+sXyFD3IFMT8=@vger.kernel.org X-Gm-Message-State: AOJu0Yznfld5o2/Y3V9JksVUe9IL7lTQ4NW3br1Q+JCTnzfFquj7Hcnh WqW5+BYQE3+RYvT+CzKM4ll+yEceqJej12LENPAcAVlHYVEnciFEbt61QKhnNnrltwo= X-Gm-Gg: AfdE7ck7NOd4CHoqV1ujjcwyVDf8IQUQPM1U67kUqZLYn2b+ZuIgLaCiAGyLq9bTL9M YN5Ql8FoEWsyMgbiEWX5/Lg/5T9zHoFza0cb3Qc9TG1B+gmz3ffM8CnsF4dIcsPj6jx225xe8dI rKukqf3HXVuVPF8m6F/yUrmj1q/Z8nvu51yvN29SCmIaROhsb9CwDAA4COadZ/ysgd9s1ZB/BD7 J2sk3rOnNijbiRelxpzkeVyv+xYLg0eu4yAmd6OAP1/keY51GvnxDhrKunsIw1w92jumMKi33Ga AqhbrDYhIRolKqynq3Vdz92dTVjoZf2OJ4ZEwLZ7sIbcSYns2VFVqWbeGypJg89HY59VzNOg7qQ lD8TK0jTnL4usblebzgwORUdMP+t1Dxy2dlgBiDcnoIn5qj8uTV9uXawoi4L02Mxa6f7O9rCFVC 8svwKCzy7HS+ab6gczpgZBFCGpHzVCPnb/zW4WOw1aTlTDPTvi3kfNFqPA/h/OwDiTZQM5A372P CUL/67JXDY6lMifsGXv5VrGcnzcZ52BXqCB2E3VCURuXDLGNHUq3+thkWItfcNzqqRBD6T8LdQB 7yWfVT3lJJKGd1uK X-Received: by 2002:a05:690c:6888:b0:80e:1ad2:afc3 with SMTP id 00721157ae682-81ecf7af68amr28483067b3.15.1784137893807; Wed, 15 Jul 2026 10:51:33 -0700 (PDT) Received: from ?IPv6:2600:1700:6476:1430:3705:6d89:7b16:2a59? ([2600:1700:6476:1430:3705:6d89:7b16:2a59]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81ebe67d857sm49978237b3.28.2026.07.15.10.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 10:51:33 -0700 (PDT) Message-ID: <00fbda82bd63f3c7560898531b97a1b061fa6e2b.camel@dubeyko.com> Subject: Re: [PATCH 4/4] ceph: release unused cap reservation on readdir error From: Viacheslav Dubeyko To: deepakraog , Ilya Dryomov , Alex Markuze , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 15 Jul 2026 10:51:31 -0700 In-Reply-To: <20260715143646.15828-4-gaikwad.dcg@gmail.com> References: <20260715143646.15828-1-gaikwad.dcg@gmail.com> <20260715143646.15828-4-gaikwad.dcg@gmail.com> Autocrypt: addr=slava@dubeyko.com; prefer-encrypt=mutual; keydata=mQINBGgaTLYBEADaJc/WqWTeunGetXyyGJ5Za7b23M/ozuDCWCp+yWUa2GqQKH40dxRIR zshgOmAue7t9RQJU9lxZ4ZHWbi1Hzz85+0omefEdAKFmxTO6+CYV0g/sapU0wPJws3sC2Pbda9/eJ ZcvScAX2n/PlhpTnzJKf3JkHh3nM1ACO3jzSe2/muSQJvqMLG2D71ccekr1RyUh8V+OZdrPtfkDam V6GOT6IvyE+d+55fzmo20nJKecvbyvdikWwZvjjCENsG9qOf3TcCJ9DDYwjyYe1To8b+mQM9nHcxp jUsUuH074BhISFwt99/htZdSgp4csiGeXr8f9BEotRB6+kjMBHaiJ6B7BIlDmlffyR4f3oR/5hxgy dvIxMocqyc03xVyM6tA4ZrshKkwDgZIFEKkx37ec22ZJczNwGywKQW2TGXUTZVbdooiG4tXbRBLxe ga/NTZ52ZdEkSxAUGw/l0y0InTtdDIWvfUT+WXtQcEPRBE6HHhoeFehLzWL/o7w5Hog+0hXhNjqte fzKpI2fWmYzoIb6ueNmE/8sP9fWXo6Av9m8B5hRvF/hVWfEysr/2LSqN+xjt9NEbg8WNRMLy/Y0MS p5fgf9pmGF78waFiBvgZIQNuQnHrM+0BmYOhR0JKoHjt7r5wLyNiKFc8b7xXndyCDYfniO3ljbr0j tXWRGxx4to6FwARAQABtCZWaWFjaGVzbGF2IER1YmV5a28gPHNsYXZhQGR1YmV5a28uY29tPokCVw QTAQoAQQIbAQUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBFXDC2tnzsoLQtrbBDlc2cL fhEB1BQJoGl5PAhkBAAoJEDlc2cLfhEB17DsP/jy/Dx19MtxWOniPqpQf2s65enkDZuMIQ94jSg7B F2qTKIbNR9SmsczjyjC+/J7m7WZRmcqnwFYMOyNfh12aF2WhjT7p5xEAbvfGVYwUpUrg/lcacdT0D Yk61GGc5ZB89OAWHLr0FJjI54bd7kn7E/JRQF4dqNsxU8qcPXQ0wLHxTHUPZu/w5Zu/cO+lQ3H0Pj pSEGaTAh+tBYGSvQ4YPYBcV8+qjTxzeNwkw4ARza8EjTwWKP2jWAfA/ay4VobRfqNQ2zLoo84qDtN Uxe0zPE2wobIXELWkbuW/6hoQFPpMlJWz+mbvVms57NAA1HO8F5c1SLFaJ6dN0AQbxrHi45/cQXla 9hSEOJjxcEnJG/ZmcomYHFneM9K1p1K6HcGajiY2BFWkVet9vuHygkLWXVYZ0lr1paLFR52S7T+cf 6dkxOqu1ZiRegvFoyzBUzlLh/elgp3tWUfG2VmJD3lGpB3m5ZhwQ3rFpK8A7cKzgKjwPp61Me0o9z HX53THoG+QG+o0nnIKK7M8+coToTSyznYoq9C3eKeM/J97x9+h9tbizaeUQvWzQOgG8myUJ5u5Dr4 6tv9KXrOJy0iy/dcyreMYV5lwODaFfOeA4Lbnn5vRn9OjuMg1PFhCi3yMI4lA4umXFw0V2/OI5rgW BQELhfvW6mxkihkl6KLZX8m1zcHitCpWaWFjaGVzbGF2IER1YmV5a28gPFNsYXZhLkR1YmV5a29Aa WJtLmNvbT6JAlQEEwEKAD4WIQRVwwtrZ87KC0La2wQ5XNnC34RAdQUCaBpd7AIbAQUJA8JnAAULCQ gHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA5XNnC34RAdYjFEACiWBEybMt1xjRbEgaZ3UP5i2bSway DwYDvgWW5EbRP7JcqOcZ2vkJwrK3gsqC3FKpjOPh7ecE0I4vrabH1Qobe2N8B2Y396z24mGnkTBbb 16Uz3PC93nFN1BA0wuOjlr1/oOTy5gBY563vybhnXPfSEUcXRd28jI7z8tRyzXh2tL8ZLdv1u4vQ8 E0O7lVJ55p9yGxbwgb5vXU4T2irqRKLxRvU80rZIXoEM7zLf5r7RaRxgwjTKdu6rYMUOfoyEQQZTD 4Xg9YE/X8pZzcbYFs4IlscyK6cXU0pjwr2ssjearOLLDJ7ygvfOiOuCZL+6zHRunLwq2JH/RmwuLV mWWSbgosZD6c5+wu6DxV15y7zZaR3NFPOR5ErpCFUorKzBO1nA4dwOAbNym9OGkhRgLAyxwpea0V0 ZlStfp0kfVaSZYo7PXd8Bbtyjali0niBjPpEVZdgtVUpBlPr97jBYZ+L5GF3hd6WJFbEYgj+5Af7C UjbX9DHweGQ/tdXWRnJHRzorxzjOS3003ddRnPtQDDN3Z/XzdAZwQAs0RqqXrTeeJrLppFUbAP+HZ TyOLVJcAAlVQROoq8PbM3ZKIaOygjj6Yw0emJi1D9OsN2UKjoe4W185vamFWX4Ba41jmCPrYJWAWH fAMjjkInIPg7RLGs8FiwxfcpkILP0YbVWHiNAabQoVmlhY2hlc2xhdiBEdWJleWtvIDx2ZHViZXlr b0BrZXJuZWwub3JnPokCVAQTAQoAPhYhBFXDC2tnzsoLQtrbBDlc2cLfhEB1BQJoVemuAhsBBQkDw mcABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEDlc2cLfhEB1GRwP/1scX5HO9Sk7dRicLD/fxo ipwEs+UbeA0/TM8OQfdRI4C/tFBYbQCR7lD05dfq8VsYLEyrgeLqP/iRhabLky8LTaEdwoAqPDc/O 9HRffx/faJZqkKc1dZryjqS6b8NExhKOVWmDqN357+Cl/H4hT9wnvjCj1YEqXIxSd/2Pc8+yw/KRC AP7jtRzXHcc/49Lpz/NU5irScusxy2GLKa5o/13jFK3F1fWX1wsOJF8NlTx3rLtBy4GWHITwkBmu8 zI4qcJGp7eudI0l4xmIKKQWanEhVdzBm5UnfyLIa7gQ2T48UbxJlWnMhLxMPrxgtC4Kos1G3zovEy Ep+fJN7D1pwN9aR36jVKvRsX7V4leIDWGzCdfw1FGWkMUfrRwgIl6i3wgqcCP6r9YSWVQYXdmwdMu 1RFLC44iF9340S0hw9+30yGP8TWwd1mm8V/+zsdDAFAoAwisi5QLLkQnEsJSgLzJ9daAsE8KjMthv hUWHdpiUSjyCpigT+KPl9YunZhyrC1jZXERCDPCQVYgaPt+Xbhdjcem/ykv8UVIDAGVXjuk4OW8la nf8SP+uxkTTDKcPHOa5rYRaeNj7T/NClRSd4z6aV3F6pKEJnEGvv/DFMXtSHlbylhyiGKN2Amd0b4 9jg+DW85oNN7q2UYzYuPwkHsFFq5iyF1QggiwYYTpoVXsw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (by Flathub.org) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-07-15 at 20:06 +0530, deepakraog wrote: > ceph_readdir_prepopulate() can exit with an error after partially > consuming the request's cap reservation. Return unused reserved caps > to > the MDS client pool on the error path so they are not held until > request > teardown. The ceph-devel list has received only 4/4 patch. Is it some patchset? If so, then why we haven't received the rest patches in series? Do you have any issue related to the fix? How have you encountered the issue? Could you please explain more about the issue? Thanks, Slava. >=20 > Signed-off-by: deepakraog > --- > =C2=A0fs/ceph/inode.c | 2 ++ > =C2=A01 file changed, 2 insertions(+) >=20 > diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c > index 61d7c0b81..2d6a80054 100644 > --- a/fs/ceph/inode.c > +++ b/fs/ceph/inode.c > @@ -2188,6 +2188,8 @@ int ceph_readdir_prepopulate(struct > ceph_mds_request *req, > =C2=A0 dput(dn); > =C2=A0 } > =C2=A0out: > + if (err) > + ceph_unreserve_caps(req->r_mdsc, &req- > >r_caps_reservation); > =C2=A0 if (err =3D=3D 0 && skipped =3D=3D 0) { > =C2=A0 set_bit(CEPH_MDS_R_DID_PREPOPULATE, &req- > >r_req_flags); > =C2=A0 req->r_readdir_cache_idx =3D cache_ctl.index;