From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABB96EAC7 for ; Sun, 22 Feb 2026 03:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771732073; cv=none; b=R+iEkiEl1BuAYfisjDo1UU8obEr6R9iILycX+qF+95GLggKcbGe80kbwFls4TroVCYfEYC4whSuFH1LNNSngiATHHdQagSXl5IDR2/7Tfx2YGME5KBi254yDZDRKezty63OaLqsQoWnI+0d6xoon+QneKZn4P0DZFKrFyLFw3Ag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771732073; c=relaxed/simple; bh=haUCi/iniivJrqnb9gF2PgEYuSeZAuVw5qAA9Ax1TdI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=rAk6cOcjKqbB1G86ON+qsq7Ty01qUWynu0i40/SdKOCe4wJpXWDcWyMEJktmcliObfZ81cUDfk7lAGOxD6zIkZh4CA1xUlzAjoWHFcRD92ssiWW/genv30NA4denoagKZJrB6//vDG/gZTlhfeqyAcUduSR9OiSY1UORe3qEKpI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nyJCD5kc; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nyJCD5kc" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2aad8123335so62985ad.1 for ; Sat, 21 Feb 2026 19:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771732072; x=1772336872; darn=vger.kernel.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=dhGPtmSA562SEqvNHVKKEpslLeLOD8N4Ld8BbTIjOjI=; b=nyJCD5kcBus35LxMTCN4+48mJNivacFnemhkOrjsgeGHpasECi/QWatGL7owU1SP+t DEXybQfmv6PAZLlwAjKIs9vXadXooC8nkO1f4XLqjHkc2eVFLtpLrFqEdCL6++jRLCvH 7m4FoBOXUMoHSv/3vbUVm0LP8D+k7o9Qk2hkLGrOxeQbkVKjeKB31x1ezcgq62kmxRbD rdbQCEVuGi6mDFORhsTXU3cUviFTFFY0QzitNEUaBnUQMrgV7sHSp0BPOKdHaiD1JPgD o0KHdis4McNEJDL2Fb0f/xAEL4+yZgkYN0lMQfkj+41yVmWD9q/Kx+O5hg6ReBFE77vv IovQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771732072; x=1772336872; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dhGPtmSA562SEqvNHVKKEpslLeLOD8N4Ld8BbTIjOjI=; b=BLVnSim/lPNLWMzxrHBpfeNceRFcSGhFT8WSeuSv9yE6HHbO7coytGBrq8Z6AogFoZ D6af6MQxDgPzsi3qEVYZPfpw2X6yST+DJuTr+T+FPwH2uVLol/DIkeco5HuAbR8RpPVK 9Pj+a+PbXCPE6jBxRJfcDV1/9O9vTgWXCrqLVChQLRUrjOYzJxgs7yRwz6M6cj+Z7J04 Vs1HeDFFRc3r71b8va65gGjIKu2DU4rpNrf4dMj1/XMUiiqtwqP88OFHuP7kZJyXZQ1U dp0fQ3I5ssXXKamY9xl2JDVK1oPn1UjLBrcvsmlUk3uRjc7zUVbzF80TXmVPvnYNvXgh GvkA== X-Forwarded-Encrypted: i=1; AJvYcCWm6iOlCl+rIcDwrwEcGdLcDn9otIZbAL6FyI7zSx+128fc0HySOn+t0+TL8+n2sNVGlBGUp80lQ4we6/8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzvbpta0aJf2rLxw60WOO9Q+NQv8kSbJNZhxy9LQJ45pZy/hAIV rv3A++6J8G5slE0BnDAgR0a3spA5/bLTq6kViUyfMi+wTOzzurZXXflt46/4kBjidg== X-Gm-Gg: AZuq6aKGqQ9Nll7de4Ee6xdVVThiV5X9EaLvXcYAicnJXTGy3Dliwb52ZRhzQEtQNur PNHtag6V2nRZzo5RQnlUa77IP7hs/rcLUtXQU2iDlnkkT1QAQXpAk4I6njWML3fltsfFBo5A02H Dmg4D+DTBCu+E9jvVnUVbuFbJc40eKTPOIIKzRnw8SbzJWQq3/vylfh4tXUu+ZC/HdfN5SLEjo0 bJa6bVa0JG7JVD4z+lNEtR85vp3OcvEQDxFT2PuTJYsitVjxLZCBVAea29I6ByyDcUtKz7lyaGq nnpVkT7ouq0L81/ex+F7Cn6CZe2bvWvBwp4mPsG2td9C2ufKN8fM0w7nxJ2hgIyBC6GJ5X+JCpv 4lvsxty8pkJ4wVYSxSn8umYrLaBKstpFhe4nZptoCu11H0GuF5+nTdu34HoSoB1i5fwQ7o3Sjom tjtKxOmGTg6HeRoS6mA7eW+CWv4jRGAXVXcMbdB5OUgxVv5IdGqh5sKulAPphWBFV4SayX4Au4J qK6wmv7XAdX89Y0d/4d4TZwOHST4WntK1gwTrEsjTNb69KQS2rghw== X-Received: by 2002:a17:902:ec8f:b0:2ab:333:22d2 with SMTP id d9443c01a7336-2ad75181695mr1385005ad.20.1771732071178; Sat, 21 Feb 2026 19:47:51 -0800 (PST) Received: from [2a00:79e0:2eb0:8:dc03:fd19:e29a:8093] ([2a00:79e0:2eb0:8:dc03:fd19:e29a:8093]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad7500e189sm34537735ad.57.2026.02.21.19.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Feb 2026 19:47:50 -0800 (PST) Date: Sat, 21 Feb 2026 19:47:49 -0800 (PST) From: David Rientjes To: Sanjay Chitroda cc: Vlastimil Babka , Andrew Morton , Christoph Lameter , Roman Gushchin , Harry Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slub: drop duplicate kernel-doc for ksize() In-Reply-To: <20260220124243.3264133-1-sanjayembedded@gmail.com> Message-ID: <00fc801f-6a11-4510-2b77-a683e5e37c77@google.com> References: <20260220124243.3264133-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 20 Feb 2026, Sanjay Chitroda wrote: > From: Sanjay Chitroda > > The ksize() API is already documented in the public header, and > Documentation/core-api/mm-api.rst pulls that canonical doc into the > book. The kernel-doc block added to mm/slub.c by commit > fab0694646d7 ("mm/slab: move [__]ksize and slab_ksize() to mm/slub.c") > introduced a second definition for the same symbol in the generated > docs, which makes Sphinx emit: > > WARNING: Duplicate C declaration, also defined at core-api/mm-api:521 > Declaration is '.. c:function:: size_t ksize(const void *objp)' > > Remove the redundant kernel-doc comment from slub.c so only the > header-provided documentation is emitted. This keeps the user-visible > API documentation intact while eliminating the duplicate-declaration > warning during `make htmldocs`. > > No functional change. > > Fixes: fab0694646d7 ("mm/slab: move [__]ksize and slab_ksize() to mm/slub.c") > Signed-off-by: Sanjay Chitroda The header file kernel-doc looks equivalent without mentioning that it returns bytes. Might be best to make that clear in slab.h?