From: "Chen, Rong A" <rong.a.chen@intel.com>
To: Michael Zaidman <michael.zaidman@gmail.com>,
kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
Jiri Kosina <jikos@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [kbuild-all] Re: drivers/hid/hid-ft260.c:794:44: warning: format specifies type 'short' but the argument has type 'int'
Date: Fri, 7 May 2021 18:00:31 +0800 [thread overview]
Message-ID: <0102b8fe-3edf-3d4f-2622-d1fefb36274f@intel.com> (raw)
In-Reply-To: <20210506115546.GA1745@michael-VirtualBox>
On 5/6/2021 7:55 PM, Michael Zaidman wrote:
> On Thu, May 06, 2021 at 06:47:46AM +0800, kernel test robot wrote:
>>
>> drivers/hid/hid-ft260.c:515:59: warning: variable 'len' is uninitialized when used here [-Wuninitialized]
>> hid_err(hdev, "%s: unsupported wr len: %d\n", __func__, len);
>> ^~~
>> include/linux/hid.h:1190:30: note: expanded from macro 'hid_err'
>> dev_err(&(hid)->dev, fmt, ##__VA_ARGS__)
>> ^~~~~~~~~~~
>> include/linux/dev_printk.h:112:32: note: expanded from macro 'dev_err'
>> _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
>> ^~~~~~~~~~~
>> drivers/hid/hid-ft260.c:507:9: note: initialize the variable 'len' to silence this warning
>> int len, ret;
>> ^
>> = 0
>
> This warning has already been found and fixed by Dan Carpenter in
> the "HID: ft260: fix an error message in ft260_i2c_write_read()" commit
> on March 18, 2021.
Hi Michael,
This report is about the below warning prefixed by '>>', it's still in
mainline:
>> drivers/hid/hid-ft260.c:794:44: warning: format specifies type
'short' but the argument has type 'int' [-Wformat]
return scnprintf(buf, PAGE_SIZE, "%hi\n", le16_to_cpu(*field));
~~~ ^~~~~~~~~~~~~~~~~~~
%i
Best Regards,
Rong Chen
next prev parent reply other threads:[~2021-05-07 10:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 22:47 kernel test robot
2021-05-06 11:55 ` Michael Zaidman
2021-05-07 10:00 ` Chen, Rong A [this message]
2021-05-09 18:25 ` [kbuild-all] " Michael Zaidman
2021-05-09 19:32 ` [PATCH] HID: ft260: fix format type warning in ft260_word_show() Michael Zaidman
2021-05-09 20:39 ` Joe Perches
2021-05-10 9:17 ` Michael Zaidman
2021-05-10 9:52 ` Joe Perches
2021-05-10 10:15 ` Dan Carpenter
2021-05-10 10:22 ` Dan Carpenter
2021-05-10 12:51 ` Michael Zaidman
2021-05-10 16:30 ` [PATCH v2] " Michael Zaidman
2021-05-10 16:41 ` Joe Perches
2021-05-10 16:34 ` [PATCH v3] " Michael Zaidman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0102b8fe-3edf-3d4f-2622-d1fefb36274f@intel.com \
--to=rong.a.chen@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dan.carpenter@oracle.com \
--cc=jikos@kernel.org \
--cc=jkosina@suse.cz \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=michael.zaidman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®