From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C7133314CB for ; Tue, 27 Jan 2026 21:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769550836; cv=none; b=u8wTJf9NNXDU9tPYl8OzWD8wpYmpT5xyjutGv5HAp1QGdGXLS9LklSAJWIsnmPfAHNR5MLPZZYM95HVAHiVnxaNZweCdKYfBreoXWVs7Pz6dQGJOVjNsUYwNYDXTWwhKYbKM2w6wYOKCprLwLMJGZSIA0zOKFgFEOEZC0+m88lQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769550836; c=relaxed/simple; bh=0dVm4VUbznq0Tn+3bAgXEVSu5pdNdqlLlwfbGeK3pRc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=qv1akkYTRT4ZOY+YbeQZmKX1tMSRF5JGcgLC960KpPRvADEmTFSIZRN+xQizQFvmQJjF70EkrK/q2xLGlJzaI80wjp1s7o/8UWl0oiKxjdyDgyObw2qB6RCN9Z/W1rcgJwIkB8NEmZYalYksUGM3B/7ZIFPlbee26SXJrRGSHYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ymLLB1PZ; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ymLLB1PZ" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47fedb7c68dso63047095e9.2 for ; Tue, 27 Jan 2026 13:53:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769550832; x=1770155632; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=S6ONBdBrWL44g/dbc6EELGm2hRjj8YYj2H+Yh0hSCJs=; b=ymLLB1PZHVZMhBAdRPW4Cp9u6XhS8NQt+auxfDUk+cpL3v2nfZuSB5kmTmCaa7An9f 8AcoYLGy9pw1ERSFWqw6CypNjR+XmUytE9+kyulZKl7x2CK2cNqMjo1qZnZlryShH/c4 NxdxUZjlqbdcb5FRpwkWQ53KNx5rOJeV+369Kl5MwA3lEkBWuKK3ZvtQmuqrSQwXSvhu HjryP0q3Y7Jw8eHmlxGpX79VNxczrNuOyxSlgiqV3OQtGcXjLGI7EyFlfkiB4n4NbE2n ziAb6XVB3PGaz9eeZEeoCbpnEHxL6Mv3KoHV6rF2jcQeCKwbxNYJgYrncQ9fGHbigBot UdCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769550832; x=1770155632; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S6ONBdBrWL44g/dbc6EELGm2hRjj8YYj2H+Yh0hSCJs=; b=cwXh5pxbODDgWn43tcCoB8uH9hMNO7V8QqdoOrsag0UFzhEHj/CmEDeZduLwGy95xh L1z9APBNwh55TLXNRj9YDTIjcmPENbY/Fu39o/Q5Jz41PS3kM6DQivt5ZaEg3KA9QTrG 5lTbf2bnwXroSg1OTwewOn0DznQ+FqxmXdcEedpNslaqHzzzwgGgl9m+2JUMH9alb3PT a8CkXEI7oBfkx+Wo0oqVy1pILizwNtMoAFrPg8CsMz7pjfySbUYYCkKYB/d8gRGkaWgi shL7dxjyV95qsYCg0Y3yhC4APL4AWNZG/DvVJO8LcfFA5kROFmLGKnd2xfYBM4wEDi3N 5KvA== X-Forwarded-Encrypted: i=1; AJvYcCUy8RZyc8KVEFM1rdyl3+RbSfKF+X3SXRLrtvqM0DJEXFdDULU6H2tLocX4EfAwJ1+ES7Gk6a0x1vy9N7k=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx+LW9RgTXwwRMEoRwgS5TfE5CxucYL2JnXzWvPmOvXGh205uL UCnSKxcsFyjmc2YD/nB28KgFv4jnPg9M9FsX1do9RnNf8yJ84DYZKMqmBJZzx7TFH68= X-Gm-Gg: AZuq6aLaHMS7bEIpar6nYdrVsLn9sQH2jDsp7zbw/Q7+jlWIOGERJMxD5VI+ZA+8QMz qRPjVrGd3qrW43u/kNhCQFMOStIvBOh9HLOth35QvW0/Nrrh87G8R+BPkDq7QFwNeGGr8NwbXl9 8Q3OjZsJTzxdTswUkuYDpnpufXwv3ZXLuW5zYJnMjZUpTzPOCUCn2EanyrTDa1HtlfVe+FZYRm0 rTum/A4NTY7zrgLDIqNc2P+8x9JId8gc9rdWlBAHXosEgUyVahM3lTyo9CZLZRMmIaY3PFfwYHB LFAF62nPr9oWB56o+0ge/9kNh6NEFHaABq4kdEABPSLnpnz9VMWLlulsFVOZ5ibpfJrRMTwKIMK mWngROru+kHIRj/UtbsBrRE/7EgarIqkwcspm0h/iosNrabLLhwMwjSeGEtYZTA3IBnapZWmdLM 9DoCwNT8a64PhohKsfgxnmnqq/5k+RMT70mLU+4eutoKR2BmOnBZ8RpLo/1DxZyx/XV+APqCQ3n Q== X-Received: by 2002:a05:600c:1e1c:b0:479:2f95:5179 with SMTP id 5b1f17b1804b1-48069c161d3mr43220935e9.15.1769550831789; Tue, 27 Jan 2026 13:53:51 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:7745:d752:5f0b:2b68? ([2a01:e0a:3d9:2080:7745:d752:5f0b:2b68]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e1354205sm1918002f8f.41.2026.01.27.13.53.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 13:53:51 -0800 (PST) Message-ID: <0104896e-44d0-485a-a44e-694864c819b7@linaro.org> Date: Tue, 27 Jan 2026 22:53:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 2/7] pci: pwrctrl: add PCI pwrctrl driver for the UPD720201/UPD720202 USB 3.0 xHCI Host Controller To: Manivannan Sadhasivam Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Greg Kroah-Hartman , Geert Uytterhoeven , Magnus Damm , Bartosz Golaszewski , Bjorn Helgaas , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pci@vger.kernel.org References: <20260127-topic-sm8650-ayaneo-pocket-s2-base-v2-0-c55ec1b5d8bf@linaro.org> <20260127-topic-sm8650-ayaneo-pocket-s2-base-v2-2-c55ec1b5d8bf@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/27/26 16:53, Manivannan Sadhasivam wrote: > On Tue, Jan 27, 2026 at 10:57:29AM +0100, Neil Armstrong wrote: >> Add support fo the Renesas UPD720201/UPD720202 USB 3.0 xHCI Host Controller >> power control which connects over PCIe and requires specific power supplies >> to start up. >> > > This driver only handles the supplies. So why can't you use the existing > pwrctrl-slot driver as a fallback? It would fit with no change, but the name "slot" doesn't match the goal here, it's not a slot at all, it's an actual pcie IC. Neil > > - Mani > >> Signed-off-by: Neil Armstrong >> --- >> drivers/pci/pwrctrl/Kconfig | 10 ++++ >> drivers/pci/pwrctrl/Makefile | 2 + >> drivers/pci/pwrctrl/pci-pwrctrl-upd720201.c | 88 +++++++++++++++++++++++++++++ >> 3 files changed, 100 insertions(+) >> >> diff --git a/drivers/pci/pwrctrl/Kconfig b/drivers/pci/pwrctrl/Kconfig >> index e0f999f299bb..5a94e60d0d3e 100644 >> --- a/drivers/pci/pwrctrl/Kconfig >> +++ b/drivers/pci/pwrctrl/Kconfig >> @@ -11,6 +11,16 @@ config PCI_PWRCTRL_PWRSEQ >> select POWER_SEQUENCING >> select PCI_PWRCTRL >> >> +config PCI_PWRCTRL_UPD720201 >> + tristate "PCI Power Control driver for the UPD720201 USB3 Host Controller" >> + select PCI_PWRCTRL >> + help >> + Say Y here to enable the PCI Power Control driver of the UPD720201 >> + USB3 Host Controller. >> + >> + The voltage regulators powering the rails of the PCI slots >> + are expected to be defined in the devicetree node of the PCI device. >> + >> config PCI_PWRCTRL_SLOT >> tristate "PCI Power Control driver for PCI slots" >> select PCI_PWRCTRL >> diff --git a/drivers/pci/pwrctrl/Makefile b/drivers/pci/pwrctrl/Makefile >> index 13b02282106c..a99f85de8a3d 100644 >> --- a/drivers/pci/pwrctrl/Makefile >> +++ b/drivers/pci/pwrctrl/Makefile >> @@ -5,6 +5,8 @@ pci-pwrctrl-core-y := core.o >> >> obj-$(CONFIG_PCI_PWRCTRL_PWRSEQ) += pci-pwrctrl-pwrseq.o >> >> +obj-$(CONFIG_PCI_PWRCTRL_UPD720201) += pci-pwrctrl-upd720201.o >> + >> obj-$(CONFIG_PCI_PWRCTRL_SLOT) += pci-pwrctrl-slot.o >> pci-pwrctrl-slot-y := slot.o >> >> diff --git a/drivers/pci/pwrctrl/pci-pwrctrl-upd720201.c b/drivers/pci/pwrctrl/pci-pwrctrl-upd720201.c >> new file mode 100644 >> index 000000000000..db96bbb69c21 >> --- /dev/null >> +++ b/drivers/pci/pwrctrl/pci-pwrctrl-upd720201.c >> @@ -0,0 +1,88 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Based on upd720201.c: >> + * Copyright (C) 2024 Linaro Ltd. >> + * Author: Manivannan Sadhasivam >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +struct pci_pwrctrl_upd720201_data { >> + struct pci_pwrctrl ctx; >> + struct regulator_bulk_data *supplies; >> + int num_supplies; >> +}; >> + >> +static void devm_pci_pwrctrl_upd720201_power_off(void *data) >> +{ >> + struct pci_pwrctrl_upd720201_data *upd720201 = data; >> + >> + regulator_bulk_disable(upd720201->num_supplies, upd720201->supplies); >> + regulator_bulk_free(upd720201->num_supplies, upd720201->supplies); >> +} >> + >> +static int pci_pwrctrl_upd720201_probe(struct platform_device *pdev) >> +{ >> + struct pci_pwrctrl_upd720201_data *upd720201; >> + struct device *dev = &pdev->dev; >> + int ret; >> + >> + upd720201 = devm_kzalloc(dev, sizeof(*upd720201), GFP_KERNEL); >> + if (!upd720201) >> + return -ENOMEM; >> + >> + ret = of_regulator_bulk_get_all(dev, dev_of_node(dev), >> + &upd720201->supplies); >> + if (ret < 0) { >> + dev_err_probe(dev, ret, "Failed to get upd720201 regulators\n"); >> + return ret; >> + } >> + >> + upd720201->num_supplies = ret; >> + ret = regulator_bulk_enable(upd720201->num_supplies, upd720201->supplies); >> + if (ret < 0) { >> + dev_err_probe(dev, ret, "Failed to enable upd720201 regulators\n"); >> + regulator_bulk_free(upd720201->num_supplies, upd720201->supplies); >> + return ret; >> + } >> + >> + ret = devm_add_action_or_reset(dev, devm_pci_pwrctrl_upd720201_power_off, >> + upd720201); >> + if (ret) >> + return ret; >> + >> + pci_pwrctrl_init(&upd720201->ctx, dev); >> + >> + ret = devm_pci_pwrctrl_device_set_ready(dev, &upd720201->ctx); >> + if (ret) >> + return dev_err_probe(dev, ret, "Failed to register pwrctrl driver\n"); >> + >> + return 0; >> +} >> + >> +static const struct of_device_id pci_pwrctrl_upd720201_of_match[] = { >> + { >> + .compatible = "pci1912,0014", >> + }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(of, pci_pwrctrl_upd720201_of_match); >> + >> +static struct platform_driver pci_pwrctrl_upd720201_driver = { >> + .driver = { >> + .name = "pci-pwrctrl-upd720201", >> + .of_match_table = pci_pwrctrl_upd720201_of_match, >> + }, >> + .probe = pci_pwrctrl_upd720201_probe, >> +}; >> +module_platform_driver(pci_pwrctrl_upd720201_driver); >> + >> +MODULE_AUTHOR("Neil Armstrong "); >> +MODULE_DESCRIPTION("PCI Power Control driver for UPD720201 USB3 Host Controller"); >> +MODULE_LICENSE("GPL"); >> >> -- >> 2.34.1 >> >