From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbbJEGTE (ORCPT ); Mon, 5 Oct 2015 02:19:04 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:33493 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbbJEGTB (ORCPT ); Mon, 5 Oct 2015 02:19:01 -0400 X-AuditID: cbfee68d-f79ae6d00000149a-c1-5612165480c6 From: PINTU KUMAR To: "'Anshuman Khandual'" , akpm@linux-foundation.org, minchan@kernel.org, dave@stgolabs.net, mhocko@suse.cz, koct9i@gmail.com, rientjes@google.com, hannes@cmpxchg.org, penguin-kernel@i-love.sakura.ne.jp, bywxiaobai@163.com, mgorman@suse.de, vbabka@suse.cz, js1304@gmail.com, kirill.shutemov@linux.intel.com, alexander.h.duyck@redhat.com, sasha.levin@oracle.com, cl@linux.com, fengguang.wu@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: cpgs@samsung.com, pintu_agarwal@yahoo.com, pintu.ping@gmail.com, vishnu.ps@samsung.com, rohit.kr@samsung.com, c.rajkumar@samsung.com, sreenathd@samsung.com References: <1443696523-27262-1-git-send-email-pintu.k@samsung.com> <560D3542.6060903@linux.vnet.ibm.com> In-reply-to: <560D3542.6060903@linux.vnet.ibm.com> Subject: RE: [PATCH 1/1] mm: vmstat: Add OOM kill count in vmstat counter Date: Mon, 05 Oct 2015 11:49:13 +0530 Message-id: <010501d0ff35$def59390$9ce0bab0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQHFyC/Uoy22OwXqBhG9QnqJ8jAPkwD7GnBBnmsApGA= Content-language: en-us X-Brightmail-Tracker: H4sIAAAAAAAAA02SeUhUURjFu+/d92YcEq6Ty3UiKikkIcu1q0XbH3GVoqK0DdLRXlYuycwo GZGZbWqJOqY1TmGMhcuEOpZoZtgkblGJZqbWYFmpmVpSphXaLAX+97sfh3POx/3ErNTEycRH 41SCIk4e48ZLoN7R9+TK3c7S0NX56RKiLdfz5M9MPiSZWneSkatmSPfkF0CGjStIWY8ekPHB cpaUGbaR6/U3OPKrPR+QnkEtJCVp/RzpfKDliUk/yxH12CdAPqf+5MidH+MiUnBujCPdw3mQ TI72iciFokqGDKaeh0TX2MeSjIFUSApSMgHJzXwLNi6kuuJcjj75Ms7SWs1bES00JNDau6UM 1T0cZqihNI2nhokcEW259hvSDy/zGXqzdSftN1ZB+u1jL6Tjj7p4mnmvFNCrBck7HPdL1h0S Yo4mCopV68MlR/omKkXxeS4n0tIymDPghTQd2Ikx8sVZ7a3Qxs643VTOW1iKigG+b3L9r6nL esWmA4l5fhvgjz1Gke0xCvBEdiWXDsRiHrnjpgZ7y9wRDbH46ferVhGLdABfnM4T2WyjcbP6 sTXCDnnjjpRK63wBCsJFv18AC0O0HFf1DnEWtkcBuPrK5X/sgKfUJmtVFnngquqznI0X4yr9 KGurugTXPBux+jiiQJx1boC3aVxwTv87ayGMOuxwc+EIYwtDeFJthJYNMFqEDQ3/fFzx4+LX MAtgzZxozZxozZxozZyIQgBLgZMQHxmvjIhSeHkq5bHKhLgoz8jjsQZgPrunM5+u1IC+hrVG gMTAbb49jnAIlXLyRGVSrBH4mRtlszKnyOPmS41ThXn5+HsTP18/H+81Af5uLvZLZdO7pChK rhKiBSFeUIQpEmIEpREwYjuZ+U+1eT83LNu79VJJxZ6YwU3q2X0NqcFeJ4faDo6c0Ye3o3m1 p1f37koOZ5qOJfttD1DNBqbUyWhI+S3VtzedYeEwurdoeJM2KtI7sCv6vceNkQOB/R1bHapb dG2wpd6Z+VqxeCxks/utap8df8Dz0IhToUGHG6cyglvr9fzMFj5pzA0qj8i9PFiFUv4XofLC THEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDJsWRmVeSWpSXmKPExsVy+t9jAd1gMaEwg5cHLS3mrF/DZvHn33QW i7456hbdUyYzWVz/9obR4uUhTYvVN9cwWrx/vp7ZYvUmX4uZe+eyWvy6MJ3R4ubzOSwWKzsf sFpc3jWHzeLemv+sFpPfPWO0eNX8ndVi2df37BazW96xWlx/OY3F4tvb2+wWbUs2Mlk8b25l sVh85DazRffjZhaL2Y19jBZT+u4yOkh7LF4xhdXj8Jv3zB47Z91l91iwqdRj59pVTB6L97xk 8ti0qpPNY9OnSeweJ2b8ZvF4cmU6k8e8k4EeDw5tZvH4+PQWi8f7fVfZPPq2rGL0mDq7PkAk qoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwcYOkoK ZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjNufNrIXTBOv6OzsZmpgPC/U xcjJISFgIrF7wjVmCFtM4sK99WxdjFwcQgJLGSWe3jzEDuG8ZZT4NHEjaxcjBwebgLrEsQO8 IHERgRfMEqe/TAUrYhZYzCjR/nMaO8goIYFsieOTD7KB2JwCRhKXGjeCxYUFPCWW/D7PCGKz CKhKbL71ghXE5hWwlNjW2wNlC0r8mHyPBcRmFtCS2LytiRXClpfYvOYt1KkKEjvOvgabIyJg JTGh5TEbRI24xKQHD9knMArNQjJqFpJRs5CMmoWkZQEjyypGidSC5ILipPRco7zUcr3ixNzi 0rx0veT83E2M4JT6THoH4+Fd7ocYBTgYlXh4D8QLhgmxJpYVV+YeYpTgYFYS4X39HyjEm5JY WZValB9fVJqTWnyI0RTo2YnMUqLJ+cB0n1cSb2hsYm5qbGppYmFiZqkkznvjEEOYkEB6Yklq dmpqQWoRTB8TB6dUA2Nj1gTFyf4f517VLjx3Tk8m6U+LseGvx6E1TbNfndVSarXymZTAq8ut Vzjpeksd09UvvsKLbv3b8FGYh2F78r3trNPYrP/O+XQ++OrbZa6qh7e9XrQ89k9wYvjJeRfi grrfPwiY12L04TDXnT3/FRYd/P72e3dNfrd/1OWLq28f8KgJ9FUJapmlxFKckWioxVxUnAgA PP4NWr8DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > -----Original Message----- > From: Anshuman Khandual [mailto:khandual@linux.vnet.ibm.com] > Sent: Thursday, October 01, 2015 7:00 PM > To: Pintu Kumar; akpm@linux-foundation.org; minchan@kernel.org; > dave@stgolabs.net; mhocko@suse.cz; koct9i@gmail.com; rientjes@google.com; > hannes@cmpxchg.org; penguin-kernel@i-love.sakura.ne.jp; > bywxiaobai@163.com; mgorman@suse.de; vbabka@suse.cz; js1304@gmail.com; > kirill.shutemov@linux.intel.com; alexander.h.duyck@redhat.com; > sasha.levin@oracle.com; cl@linux.com; fengguang.wu@intel.com; linux- > kernel@vger.kernel.org; linux-mm@kvack.org > Cc: cpgs@samsung.com; pintu_agarwal@yahoo.com; pintu.ping@gmail.com; > vishnu.ps@samsung.com; rohit.kr@samsung.com; c.rajkumar@samsung.com; > sreenathd@samsung.com > Subject: Re: [PATCH 1/1] mm: vmstat: Add OOM kill count in vmstat counter > > On 10/01/2015 04:18 PM, Pintu Kumar wrote: > > This patch maintains number of oom calls and number of oom kill count > > in /proc/vmstat. > > It is helpful during sluggish, aging or long duration tests. > > Currently if the OOM happens, it can be only seen in kernel ring buffer. > > But during long duration tests, all the dmesg and /var/log/messages* > > could be overwritten. > > So, just like other counters, the oom can also be maintained in > > /proc/vmstat. > > It can be also seen if all logs are disabled in kernel. > > Makes sense. > > > > > A snapshot of the result of over night test is shown below: > > $ cat /proc/vmstat > > oom_stall 610 > > oom_kill_count 1763 > > > > Here, oom_stall indicates that there are 610 times, kernel entered > > into OOM cases. However, there were around 1763 oom killing happens. > > The OOM is bad for the any system. So, this counter can help the > > developer in tuning the memory requirement at least during initial bringup. > > Can you please fix the formatting of the commit message above ? > Not sure if there is any formatting issue here. I cannot see it. The checkpatch returns no error/warnings. Please point me out exactly, if there is any issue. > > > > Signed-off-by: Pintu Kumar > > --- > > include/linux/vm_event_item.h | 2 ++ > > mm/oom_kill.c | 2 ++ > > mm/page_alloc.c | 2 +- > > mm/vmstat.c | 2 ++ > > 4 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/vm_event_item.h > > b/include/linux/vm_event_item.h index 2b1cef8..ade0851 100644 > > --- a/include/linux/vm_event_item.h > > +++ b/include/linux/vm_event_item.h > > @@ -57,6 +57,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, > > PSWPOUT, #ifdef CONFIG_HUGETLB_PAGE > > HTLB_BUDDY_PGALLOC, HTLB_BUDDY_PGALLOC_FAIL, #endif > > + OOM_STALL, > > + OOM_KILL_COUNT, > > Removing the COUNT will be better and in sync with others. Ok, even suggested by Michal Hocko and being discussed in another thread.