From: Mike Harmon <mikeharmon@usa.net>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, faith@cs.unc.edu,
linux-scsi@vger.kernel.org
Subject: [PATCH] Future Domain SCSI controller fix for 2.4.x
Date: Mon, 14 May 2001 17:07:32 -0400 [thread overview]
Message-ID: <01051417073200.06553@hlclabs.dynip.com> (raw)
Hi, the driver for this card seems to have missed out on one of the changes
to the SCSI layer between 2.2 and 2.4. Specifically, scsi_set_pci_device
now wants an entire SCSI host object, instead of just the pci_dev part.
Without the patch, we get a null kernel pointer dereference when the driver
is initialized. With the single-line update, the driver works again. I've
also included a patch to change an udelay loop into the equivalent mdelay
call for code readability purposes. These are both against 2.4.4; please
apply.
--
Email: mikeharmon@usa.net
--- linux-2.4.4/drivers/scsi/fdomain.old Mon May 14 16:33:11 2001
+++ linux-2.4.4/drivers/scsi/fdomain.c Fri May 4 11:07:41 2001
inline static void fdomain_make_bus_idle( void )
@@ -971,7 +969,7 @@
return 0;
shpnt->irq = interrupt_level;
shpnt->io_port = port_base;
- scsi_set_pci_device(shpnt->pci_dev, pdev);
+ scsi_set_pci_device(shpnt, pdev);
shpnt->n_io_port = 0x10;
print_banner( shpnt );
--- linux-2.4.4/drivers/scsi/fdomain.old Mon May 14 16:33:11 2001
+++ linux-2.4.4/drivers/scsi/fdomain.c Fri May 4 11:07:41 2001
@@ -587,9 +587,7 @@
static void do_pause( unsigned amount ) /* Pause for amount*10
milliseconds */
{
- do {
- udelay(10*1000);
- } while (--amount);
+ mdelay(10*amount);
}
2\bø@2\b\x11
reply other threads:[~2001-05-14 20:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01051417073200.06553@hlclabs.dynip.com \
--to=mikeharmon@usa.net \
--cc=faith@cs.unc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®