From: Steven Cole <scole@lanl.gov>
To: Keith Owens <kaos@ocs.com.au>, scole@lanl.gov
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: 2.4.5-ac20 problems with drivers/net/Config.in and make xconfig
Date: Fri, 29 Jun 2001 07:31:15 -0600 [thread overview]
Message-ID: <01062907311500.01279@spc2.esa.lanl.gov> (raw)
In-Reply-To: <16590.993781130@ocs3.ocs-net>
In-Reply-To: <16590.993781130@ocs3.ocs-net>
On Thursday 28 June 2001 20:18, Keith Owens wrote:
> On Thu, 28 Jun 2001 10:05:58 -0600,
>
> Steven Cole <scole@lanl.gov> wrote:
> >[root@spc linux]# make xconfig
> >./tkparse < ../arch/i386/config.in >> kconfig.tk
> >make[1]: *** [kconfig.tk] Error 139
> >make[1]: Leaving directory `/usr/src/linux-2.4.5-ac20/scripts'
>
> Sigh. I wish people making big changes to config files would check
> that the change works for all the variants of make *config.
>
> Index: 5.52/drivers/net/Config.in
> --- 5.52/drivers/net/Config.in Fri, 29 Jun 2001 11:39:55 +1000 kaos
> (linux-2.4/l/c/9_Config.in 1.1.2.2.1.4.1.12 644) +++
> 5.52(w)/drivers/net/Config.in Fri, 29 Jun 2001 12:14:23 +1000 kaos
> (linux-2.4/l/c/9_Config.in 1.1.2.2.1.4.1.12 644) @@ -16,7 +16,7 @@ if [
> "$CONFIG_EXPERIMENTAL" = "y" ]; the
> fi
>
> if [ "$CONFIG_ISAPNP" = "y" ]; then
> - tristate 'General Instruments Surfboard 1000' CONFIG_NET_SB1000
> $CONFIG_ISAPNP + tristate 'General Instruments Surfboard 1000'
> CONFIG_NET_SB1000 fi
>
> #
> @@ -204,7 +204,6 @@ bool 'Ethernet (10 or 100Mbit)' CONFIG_N
> dep_tristate ' D-Link DE600 pocket adapter support' CONFIG_DE600
> $CONFIG_ISA dep_tristate ' D-Link DE620 pocket adapter support'
> CONFIG_DE620 $CONFIG_ISA fi
> -fi
>
> endmenu
Here is a variant of Keith's patch. The free-floating "fi" at line 207 was the result
of a deleted line "if [ "$CONFIG_NET_ETHERNET" = "y" ]; then". The indentation
was the major clue. This patch was made against 2.4.5-ac21.
Steven
--- linux/drivers/net/Config.in.original Fri Jun 29 07:17:57 2001
+++ linux/drivers/net/Config.in Fri Jun 29 07:23:02 2001
@@ -16,7 +16,7 @@
fi
if [ "$CONFIG_ISAPNP" = "y" ]; then
- tristate 'General Instruments Surfboard 1000' CONFIG_NET_SB1000 $CONFIG_ISAPNP
+ tristate 'General Instruments Surfboard 1000' CONFIG_NET_SB1000
fi
#
@@ -27,6 +27,7 @@
comment 'Ethernet (10 or 100Mbit)'
bool 'Ethernet (10 or 100Mbit)' CONFIG_NET_ETHERNET
+if [ "$CONFIG_NET_ETHERNET" = "y" ]; then
if [ "$CONFIG_ARM" = "y" ]; then
dep_bool ' ARM EBSA110 AM79C961A support' CONFIG_ARM_AM79C961A $CONFIG_ARCH_EBSA110
if [ "$CONFIG_ARCH_ACORN" = "y" ]; then
prev parent reply other threads:[~2001-06-29 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-28 16:05 Steven Cole
2001-06-29 2:18 ` Keith Owens
2001-06-29 13:31 ` Steven Cole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01062907311500.01279@spc2.esa.lanl.gov \
--to=scole@lanl.gov \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®