From: Lizhi Hou <lizhi.hou@amd.com>
To: Markus Elfring <Markus.Elfring@web.de>,
George Yang <George.Yang@amd.com>, Min Ma <min.ma@amd.com>,
Narendra Gutta <VenkataNarendraKumar.Gutta@amd.com>,
<dri-devel@lists.freedesktop.org>,
Oded Gabbay <ogabbay@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Max Zhen <max.zhen@amd.com>,
"Sonal Santan" <sonal.santan@amd.com>
Subject: Re: [PATCH 01/10] accel/amdxdna: Add a new driver for AMD AI Engine
Date: Fri, 19 Jul 2024 13:07:48 -0700 [thread overview]
Message-ID: <010a46ba-9dc4-e3e3-7894-b28b312c6ab1@amd.com> (raw)
In-Reply-To: <7a419902-f45e-45bc-bd9c-3b3e434f9e7a@web.de>
On 7/19/24 12:42, Markus Elfring wrote:
> …
>> +++ b/drivers/accel/amdxdna/amdxdna_pci_drv.c
>> @@ -0,0 +1,118 @@
> …
>> +static int amdxdna_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>> +{
> …
>> + mutex_lock(&xdna->dev_lock);
>> + ret = xdna->dev_info->ops->init(xdna);
>> + mutex_unlock(&xdna->dev_lock);
> …
>
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&xdna->dev_lock);”?
> https://elixir.bootlin.com/linux/v6.10-rc5/source/include/linux/mutex.h#L196
guard looks cleaner. We will use it. Thanks.
Lizhi
>
> Regards,
> Markus
next prev parent reply other threads:[~2024-07-19 20:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 17:51 [PATCH V1 00/10] AMD XDNA driver Lizhi Hou
2024-07-19 17:51 ` [PATCH V1 01/10] accel/amdxdna: Add a new driver for AMD AI Engine Lizhi Hou
2024-07-19 19:42 ` [PATCH " Markus Elfring
2024-07-19 20:07 ` Lizhi Hou [this message]
2024-07-19 20:33 ` Markus Elfring
2024-07-20 6:23 ` Markus Elfring
2024-07-20 7:03 ` Markus Elfring
2024-07-19 17:51 ` [PATCH V1 02/10] accel/amdxdna: Support hardware mailbox Lizhi Hou
2024-07-19 20:04 ` [PATCH " Markus Elfring
2024-07-20 8:05 ` Markus Elfring
2024-07-19 17:51 ` [PATCH V1 03/10] accel/amdxdna: Add hardware resource solver Lizhi Hou
2024-07-20 9:15 ` [PATCH " Markus Elfring
2024-07-19 17:51 ` [PATCH V1 04/10] accel/amdxdna: Add hardware context Lizhi Hou
2024-07-20 10:54 ` [PATCH " Markus Elfring
2024-07-22 16:56 ` Lizhi Hou
2024-07-19 17:51 ` [PATCH V1 05/10] accel/amdxdna: Add GEM buffer object management Lizhi Hou
2024-07-19 17:51 ` [PATCH V1 06/10] accel/amdxdna: Add command execution Lizhi Hou
2024-07-19 17:51 ` [PATCH V1 07/10] accel/amdxdna: Add suspend and resume Lizhi Hou
2024-07-19 17:51 ` [PATCH V1 08/10] accel/amdxdna: Add error handling Lizhi Hou
2024-07-19 17:51 ` [PATCH V1 09/10] accel/amdxdna: Add query functions Lizhi Hou
2024-07-19 17:51 ` [PATCH V1 10/10] accel/amdxdna: Add firmware debug buffer support Lizhi Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010a46ba-9dc4-e3e3-7894-b28b312c6ab1@amd.com \
--to=lizhi.hou@amd.com \
--cc=George.Yang@amd.com \
--cc=Markus.Elfring@web.de \
--cc=VenkataNarendraKumar.Gutta@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.zhen@amd.com \
--cc=min.ma@amd.com \
--cc=ogabbay@kernel.org \
--cc=sonal.santan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®