mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lev Makhlis <mlev@despammed.com>
To: linux-kernel@vger.kernel.org
Subject: Bug or feature? Priority in /proc/<pid>/stat for RT processes
Date: Sat, 13 Oct 2001 14:09:12 -0400	[thread overview]
Message-ID: <01101314091204.09135@portent.dyndns.org> (raw)

I have noticed that when the scheduling policy of a process is SCHED_FIFO
or SCHED_RR, proc_pid_stat() in fs/proc/array.c still uses the counter field
in the task structure to calculate the priority in /proc/<pid>/stat.
For such processes, the counter field is ignored by the scheduler in favour
of the rt_priority field.  Thus, even though the actual priority is available
via sched_getparam(2), the priority in /proc/<pid>/stat -- and, consequently,
in the output of ps(1) and top(1) -- seems to be, for SCHED_FIFO/SCHED_RR
processes, a value that is not representative at all of how the process is
scheduled.

I have thrown together a patch to address this, but I can't say I feel
entirely comfortable about scaling from 1..99 to -20..20.

Any comments would be appreciated.

Lev Makhlis

-------------------------------CUT HERE---------------------------------
--- linux-2.4.12/fs/proc/array.c	Sat Oct 13 13:09:29 2001
+++ linux/fs/proc/array.c	Sat Oct 13 13:21:05 2001
@@ -334,8 +334,13 @@
 
 	/* scale priority and nice values from timeslices to -20..20 */
 	/* to make it look like a "normal" Unix priority/nice value  */
-	priority = task->counter;
-	priority = 20 - (priority * 10 + DEF_COUNTER / 2) / DEF_COUNTER;
+	if ((task->policy & ~SCHED_YIELD) == SCHED_OTHER) {
+		priority = task->counter;
+		priority = 20 - (priority * 10 + DEF_COUNTER / 2) / DEF_COUNTER;
+	} else {
+		priority = task->rt_priority;
+		priority = 20 - (priority * 40 + 50) / 100;
+	}
 	nice = task->nice;
 
 	read_lock(&tasklist_lock);

             reply	other threads:[~2001-10-13 18:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-13 18:09 Lev Makhlis [this message]
2001-11-19  6:01 ` Albert D. Cahalan
2001-11-19  7:31   ` Lev Makhlis
2001-11-19 11:31     ` Albert D. Cahalan
2001-11-20  4:43       ` Lev Makhlis
2001-11-20  5:51         ` Albert D. Cahalan
2001-11-21  7:36           ` Lev Makhlis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01101314091204.09135@portent.dyndns.org \
    --to=mlev@despammed.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®