From: "Guan Xuetao" <gxt@mprc.pku.edu.cn>
To: "'Arnd Bergmann'" <arnd@arndb.de>
Cc: <dmitry.torokhov@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-arch@vger.kernel.org>, "'Greg KH'" <greg@kroah.com>
Subject: RE: [PATCH 11/12] unicore32 machine related files: ps2 driver
Date: Sat, 26 Feb 2011 20:36:16 +0800 [thread overview]
Message-ID: <011101cbd5b1$c34f6880$49ee3980$@mprc.pku.edu.cn> (raw)
In-Reply-To: <201102221811.58441.arnd@arndb.de>
> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Wednesday, February 23, 2011 1:12 AM
> To: Guan Xuetao
> Cc: dmitry.torokhov@gmail.com; linux-kernel@vger.kernel.org; linux-arch@vger.kernel.org; 'Greg KH'
> Subject: Re: [PATCH 11/12] unicore32 machine related files: ps2 driver
>
> On Tuesday 22 February 2011, Guan Xuetao wrote:
> > diff --git a/drivers/input/serio/i8042-unicore32io.h b/drivers/input/serio/i8042-unicore32io.h
> > index 2cdd872..9350843 100644
> > --- a/drivers/input/serio/i8042-unicore32io.h
> > +++ b/drivers/input/serio/i8042-unicore32io.h
> > @@ -29,11 +29,11 @@
> > /*
> > * Register numbers.
> > */
> > -#define I8042_COMMAND_REG ((volatile void __iomem *)&PS2_COMMAND)
> > -#define I8042_STATUS_REG ((volatile void __iomem *)&PS2_STATUS)
> > -#define I8042_DATA_REG ((volatile void __iomem *)&PS2_DATA)
> > +#define I8042_COMMAND_REG PS2_COMMAND
> > +#define I8042_STATUS_REG PS2_STATUS
> > +#define I8042_DATA_REG PS2_DATA
>
> I wouldn't bother defining two sets of macros then. Either use PS2_COMMAND
> in the driver, or define I8042_COMMAND_REG in the place where you currently
> define PS2_COMMAND.
All I8042_*_REGs are explicitly defined in i8042-*io.h files.
And I want to reserve the original register names in unicore32 namespace.
>
> Aside from this, it looks good.
>
> Arnd
Thanks & Regards.
Guan Xuetao
prev parent reply other threads:[~2011-02-26 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 7:52 Guan Xuetao
2011-02-17 17:03 ` Arnd Bergmann
2011-02-18 10:28 ` Guan Xuetao
2011-02-18 10:33 ` Arnd Bergmann
2011-02-22 14:26 ` Guan Xuetao
2011-02-22 17:11 ` Arnd Bergmann
2011-02-26 12:36 ` Guan Xuetao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011101cbd5b1$c34f6880$49ee3980$@mprc.pku.edu.cn' \
--to=gxt@mprc.pku.edu.cn \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®