From: Shuah Khan <skhan@linuxfoundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Valentin Schneider <vschneid@redhat.com>,
Mel Gorman <mgorman@suse.de>,
Steven Rostedt <rostedt@goodmis.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>,
Yury Norov <yury.norov@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Carlos O'Donell <carlos@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v1 2/2] selftests/rseq: Fix mm_cid test failure
Date: Fri, 4 Oct 2024 13:18:04 -0600 [thread overview]
Message-ID: <01153485-ea70-47f7-ab6b-2c17496ab8ff@linuxfoundation.org> (raw)
In-Reply-To: <20241004004439.1673801-3-mathieu.desnoyers@efficios.com>
On 10/3/24 18:44, Mathieu Desnoyers wrote:
> Adapt the rseq.c/rseq.h code to follow GNU C library changes introduced by:
>
> commit 2e456ccf0c34 ("Linux: Make __rseq_size useful for feature detection (bug 31965)")
>
> Without this fix, rseq selftests for mm_cid fail:
>
> ./run_param_test.sh
> Default parameters
> Running test spinlock
> Running compare-twice test spinlock
> Running mm_cid test spinlock
> Error: cpu id getter unavailable
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> CC: Boqun Feng <boqun.feng@gmail.com>
> CC: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> CC: Carlos O'Donell <carlos@redhat.com>
> CC: Florian Weimer <fweimer@redhat.com>
> ---
> tools/testing/selftests/rseq/rseq.c | 109 +++++++++++++++++++---------
> tools/testing/selftests/rseq/rseq.h | 10 +--
> 2 files changed, 76 insertions(+), 43 deletions(-)
>
Looks good to me.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Peter, Ingo - let me know if you plan to take this through
one of your trees. Otherwise I will pick it up.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-10-04 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 0:44 [PATCH v1 0/2] RSEQ updates for 6.12 Mathieu Desnoyers
2024-10-04 0:44 ` [PATCH v1 1/2] sched: Improve cache locality of RSEQ concurrency IDs for intermittent workloads Mathieu Desnoyers
2024-10-09 9:07 ` Peter Zijlstra
2024-10-09 13:21 ` Mathieu Desnoyers
2024-10-04 0:44 ` [PATCH v1 2/2] selftests/rseq: Fix mm_cid test failure Mathieu Desnoyers
2024-10-04 19:18 ` Shuah Khan [this message]
2024-10-08 14:56 ` Mathieu Desnoyers
2024-10-08 21:29 ` Shuah Khan
2024-10-09 1:28 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01153485-ea70-47f7-ab6b-2c17496ab8ff@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=boqun.feng@gmail.com \
--cc=bsegall@google.com \
--cc=carlos@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=fweimer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®