From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3024BEB64DA for ; Fri, 16 Jun 2023 13:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345613AbjFPNTa (ORCPT ); Fri, 16 Jun 2023 09:19:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345597AbjFPNTR (ORCPT ); Fri, 16 Jun 2023 09:19:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B02592D6B for ; Fri, 16 Jun 2023 06:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686921511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wLIOb+a2wstZ29K3bzTPcm77FOoyIKi9zKAYbmzihy0=; b=SFgFPIxYKR4gTCHVnXaKLEM+kVwUsf7kWmBi7NFrta52NpWBYTQL+UvhbbR9kXrjJSMf/+ ReSPwy7jz4QnAHhpwk0Sf1z602qjhnzLTfU+g/2zCGR+LewrDtXSfchOqL1yhZEQN57vDE rvTiNLR/cAKR+AlYCb+isQE7ZpyxkbY= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-PTUkPYLoPeyQBc2X6cQgWw-1; Fri, 16 Jun 2023 09:18:26 -0400 X-MC-Unique: PTUkPYLoPeyQBc2X6cQgWw-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-98655eb409aso34452866b.2 for ; Fri, 16 Jun 2023 06:18:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686921505; x=1689513505; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wLIOb+a2wstZ29K3bzTPcm77FOoyIKi9zKAYbmzihy0=; b=K3VG2gQhoNGfXG029WyIdNOyHKzbqijD8hqLavm+rpTbql97mNNaX/gUxTINIIKePS N9Vb68qacrre//dDwMm0pBlErqfx8I+iLeD9Wa5XYK0Tw/6xoQOvNqEUXUp0vyqaSbHA eOgK6adP2P1RmW4KfKMBBpOwoXPJA/co/Un6UNXUejXVhfFJ73AOPgMSLDevybDKOSdR q/+h3YgrPR0waYf60ba8mqLNUhRjf+52wbwp1kPiohYU/+STjxhlZux1vSXVuz536Yg0 jDLxT3etgVvMR1+taX3O3T9mFPQuTL+NExCvytYmMh7D1vTtHn54K1IUJnxCXGKbbkTZ 9r/A== X-Gm-Message-State: AC+VfDzKhg2IVj5yaUoDHFXliUKCVV2Nj4fLOv8uwgDPMUnPkQvYlC4o m7EwLOokjkilUGQwe1thy55zRkIrtQBv7IebJtCdCM2+b3QK+PJcyQf/GugrbxEL6PjyTqfhDhE WKQzHxJY1HoNc+o+dcfWa2gqK X-Received: by 2002:a17:907:62a1:b0:977:befe:d888 with SMTP id nd33-20020a17090762a100b00977befed888mr2069601ejc.13.1686921505552; Fri, 16 Jun 2023 06:18:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7KyRgk64pRdV+kUcpS375HlH5soMGx18ivEQqrRikgMzb/QTnLolrS9/BwR2Dl3tXp3BDLpA== X-Received: by 2002:a17:907:62a1:b0:977:befe:d888 with SMTP id nd33-20020a17090762a100b00977befed888mr2069590ejc.13.1686921505268; Fri, 16 Jun 2023 06:18:25 -0700 (PDT) Received: from [192.168.0.224] (host-79-49-207-213.retail.telecomitalia.it. [79.49.207.213]) by smtp.gmail.com with ESMTPSA id n4-20020a17090625c400b00982cfe1fe5dsm1405234ejb.65.2023.06.16.06.18.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jun 2023 06:18:24 -0700 (PDT) Message-ID: <01191fe9-72f5-e9a3-ea11-2f0ce8a2933b@redhat.com> Date: Fri, 16 Jun 2023 15:18:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [RFC PATCH V3 5/6] sched/fair: Add trivial fair server Content-Language: en-US To: Peter Zijlstra , Daniel Bristot de Oliveira Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org, Luca Abeni , Tommaso Cucinotta , Thomas Gleixner , Joel Fernandes , Vineeth Pillai , Shuah Khan References: <8db5a49ea92ad8b875d331d6136721645a382fe8.1686239016.git.bristot@kernel.org> <20230616125946.GN83892@hirez.programming.kicks-ass.net> <20230616131243.GO83892@hirez.programming.kicks-ass.net> From: Daniel Bristot de Oliveira In-Reply-To: <20230616131243.GO83892@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/16/23 15:12, Peter Zijlstra wrote: > On Fri, Jun 16, 2023 at 03:00:57PM +0200, Daniel Bristot de Oliveira wrote: >> On 6/16/23 14:59, Peter Zijlstra wrote: >>> On Thu, Jun 08, 2023 at 05:58:17PM +0200, Daniel Bristot de Oliveira wrote: >>>> +void fair_server_init(struct rq *rq) >>>> +{ >>>> + struct sched_dl_entity *dl_se = &rq->fair_server; >>>> + >>>> + init_dl_entity(dl_se); >>>> + >>>> + dl_se->dl_runtime = TICK_NSEC; >>>> + dl_se->dl_deadline = 20 * TICK_NSEC; >>>> + dl_se->dl_period = 20 * TICK_NSEC; >>>> + >>>> + dl_server_init(dl_se, rq, fair_server_has_tasks, fair_server_pick); >>>> +} >>> >>> These here numbers should obviously become a tunable somewhere... :-) >> >> From sched_rt_runtime and sched_rt_period, no? > > Well, probably new names. IIRC those are also limits on the whole > rt-cgroup mess, so e can't trivially change it without also ripping all > that out, and that's a little bit more work. > > Ripping out the basic throttle is much simpler than replacing all that > and should be done earlier. > Life is easier then. Should them be a sysctl? Like: kernel.sched_other_min_runtime_us ? kernel.sched_other_min_period_us ? I bet you can come up with better names. -- Daniel